From: Ani Sinha <anisinha@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: alex.bennee@linaro.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
wainersm@redhat.com, bleal@redhat.com, qemu-devel@nongnu.org,
"Michael S. Tsirkin" <mst@redhat.com>,
berrange@redhat.com
Subject: Re: [PATCH 0/2] Add mformat and xorriso dependencies in containers
Date: Thu, 4 May 2023 12:40:12 +0530 [thread overview]
Message-ID: <602A585B-01D1-4140-899F-F7E3A5045E47@redhat.com> (raw)
In-Reply-To: <8d7e46ec-95c0-5c4a-a843-20106576e9ba@redhat.com>
> On 04-May-2023, at 12:05 PM, Thomas Huth <thuth@redhat.com> wrote:
>
> On 03/05/2023 16.55, Ani Sinha wrote:
>> mformat and xorriso tools are needed by biosbits avocado tests. This patchset
>> adds those two tools in the docker container images.
>
> tests/qtest/cdrom-test.c already uses genisoimage to create ISO images, and the containers already have that tool installed. Could you maybe switch the biosbits test to use that tool? Or the other way round? ... at least having two tools to create ISO images in our containers sounds IMHO excessive.
The dependency comes from the use of grub-mkrescue in the avocado test in order to generate the iso with the bios bits enabled grub and boot off with it. Grub-mkrescue is a bash script that uses mformat and xorriso.
next prev parent reply other threads:[~2023-05-04 7:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 14:55 [PATCH 0/2] Add mformat and xorriso dependencies in containers Ani Sinha
2023-05-03 14:55 ` [PATCH 1/2] tests: libvirt-ci: Update to commit 'c8971e90ac' to pull in mformat and xorriso Ani Sinha
2023-05-03 14:55 ` [PATCH 2/2] tests/lcitool: Add mtools and xorriso as dependency for bios bits avocado tests Ani Sinha
2023-05-04 6:35 ` [PATCH 0/2] Add mformat and xorriso dependencies in containers Thomas Huth
2023-05-04 7:10 ` Ani Sinha [this message]
2023-05-04 7:13 ` Thomas Huth
2023-05-04 8:58 ` Daniel P. Berrangé
2023-05-04 9:08 ` Ani Sinha
2023-05-04 8:02 ` Daniel P. Berrangé
2023-05-04 8:22 ` Ani Sinha
2023-05-04 8:25 ` Daniel P. Berrangé
2023-05-04 11:32 ` Ani Sinha
2023-05-04 8:49 ` Ani Sinha
2023-05-04 9:17 ` Ani Sinha
2023-05-04 9:35 ` Daniel P. Berrangé
2023-05-04 10:13 ` Thomas Huth
2023-05-04 15:56 ` Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=602A585B-01D1-4140-899F-F7E3A5045E47@redhat.com \
--to=anisinha@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).