From: "Cédric Le Goater" <clg@kaod.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Joel Stanley <joel@jms.id.au>, <qemu-arm@nongnu.org>,
Troy Lee <leetroy@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Steven Lee <steven_lee@aspeedtech.com>,
Jamin Lin <jamin_lin@aspeedtech.com>
Subject: Re: [PATCH] hw/arm/aspeed: Remove ast2700fc self-aliasing
Date: Tue, 21 Oct 2025 14:32:10 +0200 [thread overview]
Message-ID: <604f5f76-7a8b-4afc-a6e8-7b4fab72678b@kaod.org> (raw)
In-Reply-To: <20251021110427.93991-1-philmd@linaro.org>
On 10/21/25 13:04, Philippe Mathieu-Daudé wrote:
> Remove pointless alias to the very same machine:
>
> $ qemu-system-aarch64 -M help | fgrep ast2700fc
> ast2700fc ast2700 full core support (alias of ast2700fc)
> ast2700fc ast2700 full core support
>
> Fixes: a74faf35efc ("hw/arm: Introduce ASPEED AST2700 A1 full core machine")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/arm/aspeed_ast27x0-fc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/arm/aspeed_ast27x0-fc.c b/hw/arm/aspeed_ast27x0-fc.c
> index a61ecff3909..463dd30cc5d 100644
> --- a/hw/arm/aspeed_ast27x0-fc.c
> +++ b/hw/arm/aspeed_ast27x0-fc.c
> @@ -180,7 +180,6 @@ static void ast2700fc_class_init(ObjectClass *oc, const void *data)
> {
> MachineClass *mc = MACHINE_CLASS(oc);
>
> - mc->alias = "ast2700fc";
> mc->desc = "ast2700 full core support";
> mc->init = ast2700fc_init;
> mc->no_floppy = 1;
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Thanks,
C.
next prev parent reply other threads:[~2025-10-21 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 11:04 [PATCH] hw/arm/aspeed: Remove ast2700fc self-aliasing Philippe Mathieu-Daudé
2025-10-21 12:32 ` Cédric Le Goater [this message]
2025-10-27 19:18 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=604f5f76-7a8b-4afc-a6e8-7b4fab72678b@kaod.org \
--to=clg@kaod.org \
--cc=andrew@codeconstruct.com.au \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=leetroy@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).