qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Ari Sundholm <ari@tuxera.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Aapo Vienamo <aapo@tuxera.com>,
	Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/5] block: Add blklogwrites
Date: Fri, 1 Jun 2018 10:44:55 -0500	[thread overview]
Message-ID: <6055b0e1-d073-e504-dd9f-1cf8e161ded0@redhat.com> (raw)
In-Reply-To: <e6bbc05d-eaf1-dffc-6f62-c8a5005189e2@tuxera.com>

On 06/01/2018 10:15 AM, Ari Sundholm wrote:
> Thank you.
> 
> I'll try to get a new, more proper version of the patchset out for 
> review/comments next week. Sorry for the sloppiness in this first version!

Looking forward to it, even if, as Stefan pointed out, we can already do 
everything by use of the existing quorum driver and a custom NBD server.

And don't worry about the patch not being perfect the first time - 
that's just a typical part of the review process.  Although unintended 
on my end, I know that my reviews can be perceived as coming across 
rather negatively, especially when I don't always remember to also 
express my appreciation for the efforts you've already put into writing 
a patch.  The community is always better when we remember to treat 
newcomers (and long-time contributors) nicely, regardless of the outcome 
of the patch review process; and the reason we review things is so that 
however sloppy a first draft was, the final product is a lot better!

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

  reply	other threads:[~2018-06-01 15:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31 21:17 [Qemu-devel] [PATCH 1/5] block: Add blklogwrites Ari Sundholm
2018-05-31 21:17 ` [Qemu-devel] [PATCH 2/5] block: Add a mechanism for passing a block driver a block configuration Ari Sundholm
2018-05-31 21:17   ` [Qemu-devel] [PATCH 3/5] hw/scsi/scsi-disk: Always apply block configuration to block driver Ari Sundholm
2018-05-31 21:17     ` [Qemu-devel] [PATCH 4/5] block/blklogwrites: Use block limits from the backend block configuration Ari Sundholm
2018-05-31 21:17       ` [Qemu-devel] [PATCH 5/5] block/blklogwrites: Use the block device logical sector size when logging writes Ari Sundholm
2018-06-01 12:26 ` [Qemu-devel] [PATCH 1/5] block: Add blklogwrites Eric Blake
2018-06-01 13:31   ` Ari Sundholm
2018-06-01 15:05     ` Eric Blake
2018-06-01 15:15       ` Ari Sundholm
2018-06-01 15:44         ` Eric Blake [this message]
2018-06-04  9:59   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2018-06-01 13:32 ` Stefan Hajnoczi
2018-06-01 14:24   ` Ari Sundholm
2018-06-04  9:51     ` Stefan Hajnoczi
2018-06-04 12:10       ` Ari Sundholm
2018-06-07 12:30         ` Stefan Hajnoczi
2018-06-07 13:13           ` Ari Sundholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6055b0e1-d073-e504-dd9f-1cf8e161ded0@redhat.com \
    --to=eblake@redhat.com \
    --cc=aapo@tuxera.com \
    --cc=ari@tuxera.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).