From: Thomas Huth <thuth@redhat.com>
To: "Gerd Hoffmann" <kraxel@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>,
qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
"Richard Henderson" <rth@twiddle.net>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
"Jeff Cody" <jcody@redhat.com>, "Fam Zheng" <famz@redhat.com>,
"John Snow" <jsnow@redhat.com>, "Stefan Weil" <sw@weilnetz.de>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Ronnie Sahlberg" <ronniesahlberg@gmail.com>,
"Peter Lieven" <pl@kamp.de>, "Eric Blake" <eblake@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Alberto Garcia" <berto@igalia.com>,
"Josh Durgin" <jdurgin@redhat.com>,
"Hitoshi Mitake" <mitake.hitoshi@lab.ntt.co.jp>,
"Liu Yuan" <namei.unix@gmail.com>,
"Richard W.M. Jones" <rjones@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Greg Kurz" <groug@kaod.org>,
"Ben Warren" <ben@skyportsystems.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Shannon Zhao" <zhaoshenglong@huawei.com>,
"Michael Walle" <michael@walle.cc>,
"Keith Busch" <keith.busch@intel.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Fabien Chouteau" <chouteau@adacore.com>,
"Amit Shah" <amit@kernel.org>,
"Marcel Apfelbaum" <marcel@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Alexander Graf" <agraf@suse.de>,
"Cornelia Huck" <cohuck@redhat.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Corey Minyard" <minyard@acm.org>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Peter Chubb" <peter.chubb@nicta.com.au>,
"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
"Jason Wang" <jasowang@redhat.com>,
"Yongbok Kim" <yongbok.kim@mips.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Jiri Pirko" <jiri@resnulli.us>,
"Yuval Shaia" <yuval.shaia@oracle.com>,
"David Hildenbrand" <david@redhat.com>,
"Hannes Reinecke" <hare@suse.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Andrzej Zaborowski" <balrogg@gmail.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
"Juan Quintela" <quintela@redhat.com>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Andreas Färber" <afaerber@suse.de>,
"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
"Riku Voipio" <riku.voipio@iki.fi>,
"Zhang Chen" <zhangckid@gmail.com>,
"Li Zhijian" <lizhijian@cn.fujitsu.com>,
"Wen Congyang" <wencongyang2@huawei.com>,
"Xie Changlong" <xiechanglong.d@gmail.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
kvm@vger.kernel.org, qemu-block@nongnu.org,
sheepdog@lists.wpkg.org, qemu-arm@nongnu.org,
xen-devel@lists.xenproject.org, qemu-ppc@nongnu.org,
qemu-s390x@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu: include generated files with <> and not ""
Date: Tue, 20 Mar 2018 14:46:46 +0100 [thread overview]
Message-ID: <6061af99-0c27-e02b-e185-fe1dfca1a96a@redhat.com> (raw)
In-Reply-To: <20180320133216.u4hdijttdnyjbfpu@sirius.home.kraxel.org>
On 20.03.2018 14:32, Gerd Hoffmann wrote:
> Hi,
>
>>> So for these, we should use "". None of these are generated files though.
>>
>> That leads to crazy inconsistent message for developers where 50% of QEMU
>> header files must use <> and the other 50% of header files must use "".
>
> The rules are pretty simple though:
>
> (1) Headers which are generated use <>.
> (2) Headers which are in include/ use <>.
> (3) Headers sitting in the same directory as the source files use "".
Ugh, no. Please don't. The normal way of including header files in QEMU
is to use "" - also for headers that are not in the same directory. For
example just do a
grep -r '^#include.*hw/' hw/
from the top directory and you'll see what I mean. Changing that rule is
crazy. So please, let's just fix the configure script to detect some
more stale files in the source tree, and we're done.
Thomas
next prev parent reply other threads:[~2018-03-20 13:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 1:54 [Qemu-devel] [PATCH] qemu: include generated files with <> and not "" Michael S. Tsirkin
2018-03-20 8:58 ` Laurent Vivier
2018-03-20 9:44 ` Daniel P. Berrangé
2018-03-20 10:01 ` Peter Maydell
2018-03-20 10:27 ` Daniel P. Berrangé
2018-03-20 11:52 ` Michael S. Tsirkin
2018-03-20 12:12 ` Michael S. Tsirkin
2018-03-20 12:18 ` Daniel P. Berrangé
2018-03-20 12:28 ` Michael S. Tsirkin
2018-03-20 12:39 ` Daniel P. Berrangé
2018-03-20 12:44 ` Michael S. Tsirkin
2018-03-20 13:32 ` Gerd Hoffmann
2018-03-20 13:41 ` Daniel P. Berrangé
2018-03-20 13:50 ` Michael S. Tsirkin
2018-03-20 13:58 ` Daniel P. Berrangé
2018-03-20 14:02 ` Michael S. Tsirkin
2018-03-20 13:54 ` Max Reitz
2018-03-20 17:12 ` Michael S. Tsirkin
2018-03-20 13:46 ` Thomas Huth [this message]
2018-03-20 13:53 ` Michael S. Tsirkin
2018-03-20 12:05 ` Michael S. Tsirkin
2018-03-21 7:16 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2018-03-21 13:08 ` Michael S. Tsirkin
2018-03-21 13:15 ` Stefan Weil
2018-03-21 13:24 ` Michael S. Tsirkin
2018-03-21 13:29 ` Daniel P. Berrangé
2018-03-21 13:42 ` Michael S. Tsirkin
2018-03-20 13:05 ` [Qemu-devel] " Michael S. Tsirkin
2018-03-20 13:10 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2018-03-20 13:30 ` Michael S. Tsirkin
2018-03-20 16:12 ` [Qemu-devel] " Eric Blake
2018-03-20 16:40 ` Daniel P. Berrangé
2018-03-20 16:51 ` Michael S. Tsirkin
2018-03-20 16:33 ` Stefan Weil
2018-03-20 17:10 ` Michael S. Tsirkin
2018-03-20 17:34 ` Daniel P. Berrangé
2018-03-20 17:49 ` Michael S. Tsirkin
2018-03-20 17:36 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6061af99-0c27-e02b-e185-fe1dfca1a96a@redhat.com \
--to=thuth@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=alex.williamson@redhat.com \
--cc=alistair@alistair23.me \
--cc=amit@kernel.org \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=balaton@eik.bme.hu \
--cc=balrogg@gmail.com \
--cc=ben@skyportsystems.com \
--cc=berrange@redhat.com \
--cc=berto@igalia.com \
--cc=borntraeger@de.ibm.com \
--cc=chouteau@adacore.com \
--cc=cohuck@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=eblake@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=groug@kaod.org \
--cc=hare@suse.com \
--cc=hpoussin@reactos.org \
--cc=imammedo@redhat.com \
--cc=jasowang@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=jcody@redhat.com \
--cc=jdurgin@redhat.com \
--cc=jiri@resnulli.us \
--cc=jsnow@redhat.com \
--cc=keith.busch@intel.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=lizhijian@cn.fujitsu.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mdroth@linux.vnet.ibm.com \
--cc=michael@walle.cc \
--cc=minyard@acm.org \
--cc=mitake.hitoshi@lab.ntt.co.jp \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=namei.unix@gmail.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=pl@kamp.de \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=quintela@redhat.com \
--cc=riku.voipio@iki.fi \
--cc=rjones@redhat.com \
--cc=ronniesahlberg@gmail.com \
--cc=rth@twiddle.net \
--cc=sheepdog@lists.wpkg.org \
--cc=sstabellini@kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=stefanha@redhat.com \
--cc=sundeep.lkml@gmail.com \
--cc=sw@weilnetz.de \
--cc=wencongyang2@huawei.com \
--cc=xen-devel@lists.xenproject.org \
--cc=xiechanglong.d@gmail.com \
--cc=yongbok.kim@mips.com \
--cc=yuval.shaia@oracle.com \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhangckid@gmail.com \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).