From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, alex.bennee@linaro.org
Subject: Re: [PATCH] acceptance: update asset hashes for the Bionic aarch64 installer
Date: Mon, 10 Aug 2020 11:35:22 +0200 [thread overview]
Message-ID: <606d1faa-1920-de51-9197-95b79466331d@redhat.com> (raw)
In-Reply-To: <06ed9cc7-2204-395c-2395-d5c750c75635@redhat.com>
On 8/10/20 11:24 AM, Paolo Bonzini wrote:
> On 10/08/20 11:06, Philippe Mathieu-Daudé wrote:
>> The 'bug' is this link is using "current" which will be a problem each
>> time Ubuntu update the installer (latest update was last Wed, Aug 5).
>>
>> Acceptance tests should be stick to a particular set of binary, knew to
>> have worked once in the past. If a new set works, I'd rather see a new
>> test added (because it might have a different QEMU coverage).
>
> That seems overkill but yeah the tests should have used
> 20101020ubuntu543.15 instead of current. I think this should get into rc4.
As our CI is not yet gating, I don't think this justifies delaying the
release (except if there is a critical bugfix on the list).
Maybe it is acceptable to simply merge the CI test fixes before the
release tag, as no code/binary is affected...
>
> Paolo
>
next prev parent reply other threads:[~2020-08-10 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 22:37 [PATCH] acceptance: update asset hashes for the Bionic aarch64 installer Paolo Bonzini
2020-08-10 9:06 ` Philippe Mathieu-Daudé
2020-08-10 9:24 ` Paolo Bonzini
2020-08-10 9:35 ` Philippe Mathieu-Daudé [this message]
2020-08-10 11:13 ` Paolo Bonzini
2020-08-10 9:40 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=606d1faa-1920-de51-9197-95b79466331d@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).