From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: "Fabiano Rosas" <farosas@suse.de>,
"Leonardo Bras Soares Passos" <lsoaresp@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
qemu-stable@nongnu.org
Subject: Re: [PATCH v2 1/4] migration/qmp: Fix crash on setting tls-authz with null
Date: Tue, 29 Aug 2023 16:12:15 +0200 [thread overview]
Message-ID: <60864c2c-9012-a2c8-58de-956a47d80108@linaro.org> (raw)
In-Reply-To: <20230825171517.1215317-2-peterx@redhat.com>
On 25/8/23 19:15, Peter Xu wrote:
> QEMU will crash if anyone tries to set tls-authz (which is a type
> StrOrNull) with 'null' value. Fix it in the easy way by converting it to
> qstring just like the other two tls parameters.
>
> Cc: qemu-stable@nongnu.org # v4.0+
> Fixes: d2f1d29b95 ("migration: add support for a "tls-authz" migration parameter")
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Reviewed-by: Fabiano Rosas <farosas@suse.de>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> migration/options.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-08-29 14:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 17:15 [PATCH v2 0/4] qapi/migration: Dedup migration parameter objects and fix tls-authz crash Peter Xu
2023-08-25 17:15 ` [PATCH v2 1/4] migration/qmp: Fix crash on setting tls-authz with null Peter Xu
2023-08-29 14:12 ` Philippe Mathieu-Daudé [this message]
2023-08-25 17:15 ` [PATCH v2 2/4] tests/migration-test: Add a test for null parameter setups Peter Xu
2023-08-25 17:33 ` Thomas Huth
2023-08-25 20:57 ` Peter Xu
2023-08-29 14:12 ` Philippe Mathieu-Daudé
2023-08-25 17:15 ` [PATCH v2 3/4] migration/qapi: Replace @MigrateSetParameters with @MigrationParameters Peter Xu
2023-08-29 11:49 ` Daniel P. Berrangé
2023-08-25 17:15 ` [PATCH v2 4/4] migration/qapi: Drop @MigrationParameter enum Peter Xu
2023-08-29 11:51 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60864c2c-9012-a2c8-58de-956a47d80108@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=lsoaresp@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).