From: Stefan Berger <stefanb@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Alexander von Gluck IV" <kallisti5@unixzen.com>,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"David CARLIER" <devnexen@gmail.com>,
kraxel@redhat.com, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 1/4] configure: Fix the _BSD_SOURCE define for the Haiku build
Date: Sat, 14 Nov 2020 18:44:27 -0500 [thread overview]
Message-ID: <60928711-0d58-7dd4-7c41-0951793ca2fe@linux.ibm.com> (raw)
In-Reply-To: <20201114165137.15379-2-thuth@redhat.com>
On 11/14/20 11:51 AM, Thomas Huth wrote:
> The Haiku VM that we are going to add is using _BSD_SOURCE instead
> of BSD_SOURCE (without initial underscore)... according to David
> Carlier, the BSD_SOURCE without underscore was likely a typo, so
> let's simply add the underscore there now.
> This fixes the build failure with the bswapXX() macros not being
> defined after including <endian.h>.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 4cef321d9d..a273a93377 100755
> --- a/configure
> +++ b/configure
> @@ -790,7 +790,7 @@ SunOS)
> ;;
> Haiku)
> haiku="yes"
> - QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS -DBSD_SOURCE $QEMU_CFLAGS"
> + QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS -D_BSD_SOURCE $QEMU_CFLAGS"
> ;;
> Linux)
> audio_drv_list="try-pa oss"
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com
next prev parent reply other threads:[~2020-11-14 23:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 16:51 [PATCH for-5.2? 0/4] Fix build failures on Haiku Thomas Huth
2020-11-14 16:51 ` [PATCH 1/4] configure: Fix the _BSD_SOURCE define for the Haiku build Thomas Huth
2020-11-14 23:44 ` Stefan Berger [this message]
2020-11-14 16:51 ` [PATCH 2/4] configure: Do not build pc-bios/optionrom on Haiku Thomas Huth
2020-11-14 23:44 ` Stefan Berger
2020-11-16 11:51 ` Philippe Mathieu-Daudé
2020-11-14 16:51 ` [PATCH 3/4] configure: Add a proper check for sys/ioccom.h and use it in tpm_ioctl.h Thomas Huth
2020-11-14 16:56 ` 罗勇刚(Yonggang Luo)
2020-11-15 14:00 ` Thomas Huth
2020-11-15 14:34 ` Paolo Bonzini
2020-11-15 15:18 ` Thomas Huth
2020-11-14 23:43 ` Stefan Berger
2020-11-15 15:23 ` [PATCH v2 " Thomas Huth
2020-11-16 11:51 ` Philippe Mathieu-Daudé
2020-11-14 16:51 ` [PATCH 4/4] tests/vm: Add Haiku test based on their vagrant images Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60928711-0d58-7dd4-7c41-0951793ca2fe@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=alex.bennee@linaro.org \
--cc=devnexen@gmail.com \
--cc=f4bug@amsat.org \
--cc=kallisti5@unixzen.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).