From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:34968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzNja-0006BD-04 for qemu-devel@nongnu.org; Thu, 28 Feb 2019 10:36:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gzNjX-0004CG-LW for qemu-devel@nongnu.org; Thu, 28 Feb 2019 10:36:29 -0500 Message-ID: <60952760a82dc603b836ca41fd0f9b1325cad635.camel@gmail.com> From: Aarushi Mehta Date: Thu, 28 Feb 2019 21:05:41 +0530 Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH v2] trivial fix of malloc to g_new in thunk List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org" Cc: qemu-trivial@nongnu.org, Stefan Hajnoczi , Julia Suvorova Signed-off-by: Aarushi Mehta --- Note that since thunking occurs throughout the lifetime of the QEMU instance, there is no matching 'free' to correct It might be valuable to edit the BiteSizedTasks to reflect that g_new is favoured over g_malloc thunk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/thunk.c b/thunk.c index d5d8645cd4..17f3d320bb 100644 --- a/thunk.c +++ b/thunk.c @@ -89,7 +89,7 @@ void thunk_register_struct(int id, const char *name, const argtype *types) for(i = 0;i < 2; i++) { offset = 0; max_align = 1; - se->field_offsets[i] = malloc(nb_fields * sizeof(int)); + se->field_offsets[i] = g_new(int, nb_fields); type_ptr = se->field_types; for(j = 0;j < nb_fields; j++) { size = thunk_type_size(type_ptr, i); -- 2.17.1 Regards Aarushi Mehta