From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6Cva-00069H-A8 for qemu-devel@nongnu.org; Mon, 14 Nov 2016 03:47:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6CvX-0006pJ-44 for qemu-devel@nongnu.org; Mon, 14 Nov 2016 03:47:46 -0500 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:34186) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c6CvW-0006iY-Ss for qemu-devel@nongnu.org; Mon, 14 Nov 2016 03:47:43 -0500 Received: by mail-wm0-x241.google.com with SMTP id g23so13289035wme.1 for ; Mon, 14 Nov 2016 00:47:21 -0800 (PST) Sender: Paolo Bonzini References: <147900720399.226.10800365976960745863@9040ca97f87d> From: Paolo Bonzini Message-ID: <6097d4f8-3b4b-166d-6a8a-41774c9f273a@redhat.com> Date: Mon, 14 Nov 2016 09:47:18 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/5] [RFC] Add HAX support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vincent Palatin , famz@redhat.com Cc: qemu-devel On 14/11/2016 09:21, Vincent Palatin wrote: > On Sun, Nov 13, 2016 at 4:20 AM, wrote: >> Hi, >> >> Your series seems to have some coding style problems. See output below for >> more information: >> >> Type: series >> Subject: [Qemu-devel] [PATCH v2 0/5] [RFC] Add HAX support >> Message-id: cover.1478863621.git.vpalatin@chromium.org >> >> === TEST SCRIPT BEGIN === >> #!/bin/bash >> >> BASE=base >> n=1 >> total=$(git log --oneline $BASE.. | wc -l) >> failed=0 >> >> # Useful git options >> git config --local diff.renamelimit 0 >> git config --local diff.renames True >> >> commits="$(git log --format=%H --reverse $BASE..)" >> for c in $commits; do >> echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..." >> if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then >> failed=1 >> echo >> fi >> n=$((n+1)) >> done >> >> exit $failed >> === TEST SCRIPT END === >> >> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 >> Switched to a new branch 'test' >> b9d801a Plumb the HAXM-based hardware acceleration support >> c855846 hax: simplify init >> 577d188 hax: remove non UG code >> edf12f7 target-i386: Add Intel HAX files >> cfebedf kvm: move cpu synchronization code >> >> === OUTPUT BEGIN === >> fatal: unrecognized argument: --no-patch >> Checking PATCH 1/5: ... >> fatal: unrecognized argument: --no-patch >> Checking PATCH 2/5: ... >> fatal: unrecognized argument: --no-patch >> Checking PATCH 3/5: ... >> fatal: unrecognized argument: --no-patch >> Checking PATCH 4/5: ... >> fatal: unrecognized argument: --no-patch >> Checking PATCH 5/5: ... >> ERROR: spaces required around that '-' (ctx:WxV) >> #158: FILE: cpus.c:1276: >> + if (SuspendThread(cpu->hThread) == (DWORD) -1) { >> ^ >> >> ERROR: spaces required around that '-' (ctx:WxV) >> #176: FILE: cpus.c:1294: >> + if (ResumeThread(cpu->hThread) == (DWORD) -1) { >> ^ >> > > Apparently I missed this couple of warnings when I did my final checkpatch pass. > At the same time, I have no idea how to solve this one, can anybody > enlighten me ? > Having a space on both sides of a unary minus doesn't seem what we want, > so I imagine something else is wrong and confuse a bit checkpatch.pl. Yes, I think it's the Win32 "DWORD" type that confuses it. You can ignore it. Paolo