qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bernhard Beschow <shentey@gmail.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	jsnow@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org,
	balaton@eik.bme.hu, philmd@linaro.org
Subject: Re: [PATCH v2 0/3] ide: implement simple legacy/native mode switching for PCI IDE controllers
Date: Thu, 02 Nov 2023 09:03:02 +0000	[thread overview]
Message-ID: <60E06D0C-329C-4A84-A53D-745730F10487@gmail.com> (raw)
In-Reply-To: <20231024224056.842607-1-mark.cave-ayland@ilande.co.uk>



Am 24. Oktober 2023 22:40:53 UTC schrieb Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>:
>This series adds a simple implementation of legacy/native mode switching for PCI
>IDE controllers and updates the via-ide device to use it.
>
>The approach I take here is to add a new pci_ide_update_mode() function which handles
>management of the PCI BARs and legacy IDE ioports for each mode to avoid exposing
>details of the internal logic to individual PCI IDE controllers.
>
>As noted in [1] this is extracted from a local WIP branch I have which contains
>further work in this area. However for the moment I've kept it simple (and
>restricted it to the via-ide device) which is good enough for Zoltan's PPC
>images whilst paving the way for future improvements after 8.2.
>
>Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

FWIW:
Reviewed-by: Bernhard Beschow <shentey@gmail.com>

>
>[1] https://lists.gnu.org/archive/html/qemu-devel/2023-10/msg05403.html
>
>v2:
>- Rebase onto master
>- Mask the bottom 4 bits of PCI_CLASS_PROG in pci_ide_update_mode() in patch 1
>- Add patch 2 to remove the default BAR addresses to avoid confusion
>- Don't set PCI_INTERRUPT_PIN directly in via_ide_reset() as it is already set
>  by pci_ide_update_mode() in patch 3, and reword the commit message accordingly
>- Add Tested-By tags from Zoltan and Bernhard
>
>
>Mark Cave-Ayland (3):
>  ide/pci.c: introduce pci_ide_update_mode() function
>  ide/via: don't attempt to set default BAR addresses
>  hw/ide/via: implement legacy/native mode switching
>
> hw/ide/pci.c         | 90 ++++++++++++++++++++++++++++++++++++++++++++
> hw/ide/via.c         | 25 ++++++++----
> include/hw/ide/pci.h |  1 +
> 3 files changed, 109 insertions(+), 7 deletions(-)
>


      parent reply	other threads:[~2023-11-02  9:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24 22:40 [PATCH v2 0/3] ide: implement simple legacy/native mode switching for PCI IDE controllers Mark Cave-Ayland
2023-10-24 22:40 ` [PATCH v2 1/3] ide/pci.c: introduce pci_ide_update_mode() function Mark Cave-Ayland
2023-11-06 14:12   ` Kevin Wolf
2023-11-06 22:41     ` Mark Cave-Ayland
2023-11-07 11:11       ` Kevin Wolf
2023-11-13 21:24         ` Mark Cave-Ayland
2023-11-13 23:47           ` BALATON Zoltan
2023-11-14 17:59           ` Kevin Wolf
2023-10-24 22:40 ` [PATCH v2 2/3] ide/via: don't attempt to set default BAR addresses Mark Cave-Ayland
2023-10-24 23:06   ` BALATON Zoltan
2023-10-24 22:40 ` [PATCH v2 3/3] hw/ide/via: implement legacy/native mode switching Mark Cave-Ayland
2023-11-06 14:35   ` Kevin Wolf
2023-11-06 16:13     ` BALATON Zoltan
2023-11-07 10:43       ` Kevin Wolf
2023-11-13 20:45         ` Mark Cave-Ayland
2023-11-14  0:04           ` BALATON Zoltan
2023-11-01 10:49 ` [PATCH v2 0/3] ide: implement simple legacy/native mode switching for PCI IDE controllers BALATON Zoltan
2023-11-02  9:03 ` Bernhard Beschow [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60E06D0C-329C-4A84-A53D-745730F10487@gmail.com \
    --to=shentey@gmail.com \
    --cc=balaton@eik.bme.hu \
    --cc=jsnow@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).