Re: [PATCH not-for-merge 0/5] Instrumentation for "Fixes around device realization"

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 5/18/20 7:19 AM, Markus Armbruster wrote:
> This is the instrumentation mentioned in "[PATCH 00/24] Fixes around
> device realization".
> 
> PATCH 2/5 might have value on its own.  You tell me.

I'd like to have 2/3 merged normally because as you described, having 
reproducible output makes testing simpler. Can you repost them with 
proper syntax/style?

I have similar hacks than 1/4/5.
What about having the warnings always displayed with warn_report() while 
running QTests? Simply checking qtest_enabled().

> 
> Shell script to smoke-test all machines:
> 
> #!/bin/sh
> success=0
> fail=0
> ulimit -c 0
> git-describe --dirty --match v\*
> git-log --oneline -1
> for i in bld/*-softmmu
> do
>      t=${i%-softmmu}
>      t=${t##*/}
>      q=$i/qemu-system-$t
>      echo "= $t ="
> 
>      for m in `$q -M help | sed -n '/(alias of/d;2,$s/ .*//p'`
>      do
> 	echo "== $m =="
> 	echo -e 'info qom-tree\ninfo qtree\nq' | $q -S -accel qtest -display none -L smoke-mon-roms -M $m -monitor stdio
> 	if [ $? -eq 0 ]
> 	then echo "*** Success: $m ***"; let success++
> 	else echo "*** Fail: $m"; let fail++
> 	fi
>      done
> done
> echo $success succeeded, $fail failed
> 
> 
> Markus Armbruster (5):
>    qom: Instrument to detect missed realize
>    qom: Make "info qom-tree" show children sorted
>    qdev: Make "info qtree" show child devices sorted by QOM path
>    qdev: Instrument to detect missed QOM parenting
>    qdev: Instrument to detect bus mismatch
> 
>   hw/core/qdev.c     | 17 ++++++++++++++++
>   qdev-monitor.c     | 32 ++++++++++++++++++++++++++++-
>   qom/qom-hmp-cmds.c | 51 +++++++++++++++++++++++++++++++++++++++++++++-
>   3 files changed, 98 insertions(+), 2 deletions(-)
>