qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Sebastian Färber" <sfaerber82@gmail.com>
To: Josh Durgin <jdurgin@redhat.com>, Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, jcody@redhat.com,
	mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block/rbd: add .bdrv_reopen_prepare() stub
Date: Wed, 18 May 2016 09:36:40 +0200	[thread overview]
Message-ID: <60ba4b62-e26c-14ce-fa16-e8135690f8f6@gmail.com> (raw)
In-Reply-To: <573B676F.2080302@redhat.com>

> 
> There's no need to reset the librados state, so connections to the
> cluster can stick around. I'm a bit unclear on the bdrv_reopen_*
> functions though - what is their intended use and semantics?

My motivation for implementing this basic reopen support is getting
active block commit in qemu (driven by libvirt) to work for rbd.
For example:
- VM is running and using rbd device as primary disk
- Create external local qcow2 snapshot with rbd as backing device
- All writes end up in local qcow2 file
- Do active block commit to get changes back to rbd after a while

Without the patch the last part (active block commit) fails in qemu:
Block format 'rbd' used by device '' does not support reopening files

I think, in this case, block commit wants to switch the rbd device to RW
to make sure it can write back the changes. Which is unnecessary in this case 
because it already is writeable.

Unfortunately i don't think i can implement proper/full-blown reopen support (like gluster)
for rbd - this would be way above my head ...

Sebastian

  reply	other threads:[~2016-05-18  7:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-13  8:29 [Qemu-devel] [PATCH] block/rbd: add .bdrv_reopen_prepare() stub Sebastian Färber
2016-05-13  8:45 ` Kevin Wolf
2016-05-17 10:03   ` Sebastian Färber
2016-05-17 14:00     ` Jason Dillaman
2016-05-17 18:48     ` Josh Durgin
2016-05-18  7:36       ` Sebastian Färber [this message]
2016-05-18  8:19       ` Kevin Wolf
2016-05-18 15:54         ` Jason Dillaman
2016-05-18  5:31     ` Jeff Cody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60ba4b62-e26c-14ce-fa16-e8135690f8f6@gmail.com \
    --to=sfaerber82@gmail.com \
    --cc=jcody@redhat.com \
    --cc=jdurgin@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).