* [PATCH] hw/vfio-user: add x-pci-class-code
@ 2025-08-27 19:08 John Levon
2025-09-01 7:04 ` Cédric Le Goater
2025-09-08 14:15 ` Cédric Le Goater
0 siblings, 2 replies; 3+ messages in thread
From: John Levon @ 2025-08-27 19:08 UTC (permalink / raw)
To: qemu-devel; +Cc: Cédric Le Goater, John Levon, qemu-stable, Thanos Makatos
This new option was not added to vfio_user_pci_dev_properties, which
caused an incorrect class code for vfio-user devices.
Fixes: a59d06305fff ("vfio/pci: Introduce x-pci-class-code option")
Signed-off-by: John Levon <john.levon@nutanix.com>
---
hw/vfio-user/pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c
index be71c77729..dfaa89498d 100644
--- a/hw/vfio-user/pci.c
+++ b/hw/vfio-user/pci.c
@@ -406,6 +406,8 @@ static const Property vfio_user_pci_dev_properties[] = {
sub_vendor_id, PCI_ANY_ID),
DEFINE_PROP_UINT32("x-pci-sub-device-id", VFIOPCIDevice,
sub_device_id, PCI_ANY_ID),
+ DEFINE_PROP_UINT32("x-pci-class-code", VFIOPCIDevice,
+ class_code, PCI_ANY_ID),
DEFINE_PROP_BOOL("x-send-queued", VFIOUserPCIDevice, send_queued, false),
DEFINE_PROP_UINT32("x-msg-timeout", VFIOUserPCIDevice, wait_time, 5000),
DEFINE_PROP_BOOL("x-no-posted-writes", VFIOUserPCIDevice, no_post, false),
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/vfio-user: add x-pci-class-code
2025-08-27 19:08 [PATCH] hw/vfio-user: add x-pci-class-code John Levon
@ 2025-09-01 7:04 ` Cédric Le Goater
2025-09-08 14:15 ` Cédric Le Goater
1 sibling, 0 replies; 3+ messages in thread
From: Cédric Le Goater @ 2025-09-01 7:04 UTC (permalink / raw)
To: John Levon, qemu-devel; +Cc: qemu-stable, Thanos Makatos
On 8/27/25 21:08, John Levon wrote:
> This new option was not added to vfio_user_pci_dev_properties, which
> caused an incorrect class code for vfio-user devices.
>
> Fixes: a59d06305fff ("vfio/pci: Introduce x-pci-class-code option")
> Signed-off-by: John Levon <john.levon@nutanix.com>
> ---
> hw/vfio-user/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c
> index be71c77729..dfaa89498d 100644
> --- a/hw/vfio-user/pci.c
> +++ b/hw/vfio-user/pci.c
> @@ -406,6 +406,8 @@ static const Property vfio_user_pci_dev_properties[] = {
> sub_vendor_id, PCI_ANY_ID),
> DEFINE_PROP_UINT32("x-pci-sub-device-id", VFIOPCIDevice,
> sub_device_id, PCI_ANY_ID),
> + DEFINE_PROP_UINT32("x-pci-class-code", VFIOPCIDevice,
> + class_code, PCI_ANY_ID),
> DEFINE_PROP_BOOL("x-send-queued", VFIOUserPCIDevice, send_queued, false),
> DEFINE_PROP_UINT32("x-msg-timeout", VFIOUserPCIDevice, wait_time, 5000),
> DEFINE_PROP_BOOL("x-no-posted-writes", VFIOUserPCIDevice, no_post, false),
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Thanks,
C.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/vfio-user: add x-pci-class-code
2025-08-27 19:08 [PATCH] hw/vfio-user: add x-pci-class-code John Levon
2025-09-01 7:04 ` Cédric Le Goater
@ 2025-09-08 14:15 ` Cédric Le Goater
1 sibling, 0 replies; 3+ messages in thread
From: Cédric Le Goater @ 2025-09-08 14:15 UTC (permalink / raw)
To: John Levon, qemu-devel; +Cc: qemu-stable, Thanos Makatos
On 8/27/25 21:08, John Levon wrote:
> This new option was not added to vfio_user_pci_dev_properties, which
> caused an incorrect class code for vfio-user devices.
>
> Fixes: a59d06305fff ("vfio/pci: Introduce x-pci-class-code option")
> Signed-off-by: John Levon <john.levon@nutanix.com>
> ---
> hw/vfio-user/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c
> index be71c77729..dfaa89498d 100644
> --- a/hw/vfio-user/pci.c
> +++ b/hw/vfio-user/pci.c
> @@ -406,6 +406,8 @@ static const Property vfio_user_pci_dev_properties[] = {
> sub_vendor_id, PCI_ANY_ID),
> DEFINE_PROP_UINT32("x-pci-sub-device-id", VFIOPCIDevice,
> sub_device_id, PCI_ANY_ID),
> + DEFINE_PROP_UINT32("x-pci-class-code", VFIOPCIDevice,
> + class_code, PCI_ANY_ID),
> DEFINE_PROP_BOOL("x-send-queued", VFIOUserPCIDevice, send_queued, false),
> DEFINE_PROP_UINT32("x-msg-timeout", VFIOUserPCIDevice, wait_time, 5000),
> DEFINE_PROP_BOOL("x-no-posted-writes", VFIOUserPCIDevice, no_post, false),
Applied to vfio-next.
Thanks,
C.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-08 14:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-27 19:08 [PATCH] hw/vfio-user: add x-pci-class-code John Levon
2025-09-01 7:04 ` Cédric Le Goater
2025-09-08 14:15 ` Cédric Le Goater
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).