Re: [Qemu-devel] [PATCH] block: split block/qapi.c to avoid linking utilities with qapi

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1558 bytes --]

On 1/28/19 11:39 AM, Anton Kuchin wrote:
> Only part of block/qapi.c is used by qemu-io qemu-nbd and qemu-img
> and its not realy about QAPI, so move it to separate file to reduce

s/realy/really/

> amount of unused code linked to utilities and avoid unnecessary
> dependencies.

That's a decent start for a good commit message; although giving even
more details about which interfaces are candidates for moving (to make
it easier for future patches to know which of the two files to add to)
would be helpful.

Also, do you have any before/after comparisons, perhaps such as size of
the executables or of 'nm | wc' output, proving that the split makes an
obvious difference?

> 
> Signed-off-by: Anton Kuchin <antonkuchin@yandex-team.ru>
> ---
>  block.c                               |   2 +-
>  block/Makefile.objs                   |   3 +-
>  block/bdrv_info.c                     | 582 ++++++++++++++++++++++++++
>  block/qapi.c                          | 553 +-----------------------
>  hmp.c                                 |   2 +-
>  include/block/{qapi.h => bdrv_info.h} |   6 +-
>  monitor.c                             |   2 +-
>  qemu-img.c                            |   2 +-
>  qemu-io-cmds.c                        |   2 +-
>  9 files changed, 593 insertions(+), 561 deletions(-)
>  create mode 100644 block/bdrv_info.c
>  rename include/block/{qapi.h => bdrv_info.h} (97%)
> 
-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]