From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
"Ani Sinha" <ani@anisinha.ca>, "Fam Zheng" <fam@euphon.net>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Eric Blake" <eblake@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH for-7.2] Fix several typos in documentation (found by codespell)
Date: Fri, 11 Nov 2022 09:24:42 +0100 [thread overview]
Message-ID: <60bec893-c0eb-d0a3-eee7-bcd7bc482361@redhat.com> (raw)
In-Reply-To: <CAFEAcA_BC8yK8LSPkJ=whtg3K6-zgSCxjOgkwhFMAVdk04Pv2w@mail.gmail.com>
On 10/11/2022 21.10, Peter Maydell wrote:
> On Thu, 10 Nov 2022 at 19:09, Stefan Weil via <qemu-devel@nongnu.org> wrote:
>>
>> Those typos are in files which are used to generate the QEMU manual.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>>
>> I did not fix memory_region_init_resizeable_ram. That might be done after 7.2.
>>
>> Stefan
>>
>> docs/devel/acpi-bits.rst | 2 +-
>> docs/system/devices/can.rst | 2 +-
>> hw/scsi/esp.c | 6 +++---
>> include/exec/memory.h | 6 +++---
>> qapi/virtio.json | 4 ++--
>> qemu-options.hx | 6 +++---
>> tests/qtest/libqos/qgraph.h | 2 +-
>> tests/qtest/libqos/virtio-9p.c | 2 +-
>> 8 files changed, 15 insertions(+), 15 deletions(-)
>>
>> diff --git a/docs/devel/acpi-bits.rst b/docs/devel/acpi-bits.rst
>> index c9564d871a..5e22be8ef6 100644
>> --- a/docs/devel/acpi-bits.rst
>> +++ b/docs/devel/acpi-bits.rst
>> @@ -132,7 +132,7 @@ Under ``tests/avocado/`` as the root we have:
>>
>> (a) They are python2.7 based scripts and not python 3 scripts.
>> (b) They are run from within the bios bits VM and is not subjected to QEMU
>> - build/test python script maintainance and dependency resolutions.
>> + build/test python script maintenance and dependency resolutions.
>> (c) They need not be loaded by avocado framework when running tests.
>>
>>
>> diff --git a/docs/system/devices/can.rst b/docs/system/devices/can.rst
>> index fe37af8223..24b0d4cf41 100644
>> --- a/docs/system/devices/can.rst
>> +++ b/docs/system/devices/can.rst
>> @@ -169,7 +169,7 @@ and with bitrate switch::
>>
>> cangen can0 -b
>>
>> -The test can be run viceversa, generate messages in the guest system and capture them
>> +The test can be run vice-versa, generate messages in the guest system and capture them
>> in the host one and much more combinations.
>
> This isn't a grammatical use of vice-versa, so if we're touching it
> then I think the sentence should be recast, eg:
> "The test can also be run the other way around, generating
> messages in the guest system and capturing them in the host system.
> Other combinations are also possible."
Sounds reasonable! ... I'm currently assembling a pull request for misc
fixes - I can add the patch there and fix the sentence while picking it up.
Thomas
next prev parent reply other threads:[~2022-11-11 8:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 19:08 [PATCH for-7.2] Fix several typos in documentation (found by codespell) Stefan Weil via
2022-11-10 19:18 ` Michael S. Tsirkin
2022-11-10 19:50 ` Philippe Mathieu-Daudé
2022-11-10 20:10 ` Peter Maydell
2022-11-11 8:24 ` Thomas Huth [this message]
2022-11-10 20:15 ` Peter Maydell
2022-11-11 5:29 ` Ani Sinha
2022-11-11 6:56 ` Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60bec893-c0eb-d0a3-eee7-bcd7bc482361@redhat.com \
--to=thuth@redhat.com \
--cc=ani@anisinha.ca \
--cc=armbru@redhat.com \
--cc=david@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).