From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Damien Hedde <damien.hedde@greensocs.com>, qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
mark.burton@greensocs.com, edgari@xilinx.com,
mirela.grujic@greensocs.com,
"Alistair Francis" <alistair.francis@wdc.com>,
"Ani Sinha" <ani@anisinha.ca>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v3 1/3] machine: add device_type_is_dynamic_sysbus function
Date: Fri, 29 Oct 2021 19:25:52 +0200 [thread overview]
Message-ID: <60ca6d72-57fa-5c8e-1bf3-b6c21670cca8@redhat.com> (raw)
In-Reply-To: <20211029142258.484907-2-damien.hedde@greensocs.com>
On 10/29/21 16:22, Damien Hedde wrote:
> Right now the allowance check for adding a sysbus device using
> -device cli option (or device_add qmp command) is done well after
> the device has been created. It is done during the machine init done
> notifier: machine_init_notify() in hw/core/machine.c
>
> This new function will allow us to do the check at the right time and
> issue an error if it fails.
>
> Also make device_is_dynamic_sysbus() use the new function.
>
> Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
> ---
> Cc: Ani Sinha <ani@anisinha.ca>
>
> v3: change the function name (Ani)
> ---
> include/hw/boards.h | 15 +++++++++++++++
> hw/core/machine.c | 13 ++++++++++---
> 2 files changed, 25 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-10-29 17:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 14:22 [PATCH v3 0/3] Dynamic sysbus device check error report Damien Hedde
2021-10-29 14:22 ` [PATCH v3 1/3] machine: add device_type_is_dynamic_sysbus function Damien Hedde
2021-10-29 17:25 ` Philippe Mathieu-Daudé [this message]
2021-10-31 23:36 ` Alistair Francis
2021-10-29 14:22 ` [PATCH v3 2/3] qdev-monitor: Check sysbus device type before creating it Damien Hedde
2021-10-29 17:34 ` Philippe Mathieu-Daudé
2021-10-29 18:13 ` Philippe Mathieu-Daudé
2021-10-29 14:22 ` [PATCH v3 3/3] machine: remove the done notifier for dynamic sysbus device type check Damien Hedde
2021-10-29 19:59 ` Philippe Mathieu-Daudé
2021-10-29 20:00 ` [PATCH v3 0/3] Dynamic sysbus device check error report Philippe Mathieu-Daudé
2021-11-01 15:18 ` Eduardo Habkost
2021-11-01 18:30 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60ca6d72-57fa-5c8e-1bf3-b6c21670cca8@redhat.com \
--to=philmd@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=ani@anisinha.ca \
--cc=berrange@redhat.com \
--cc=damien.hedde@greensocs.com \
--cc=edgari@xilinx.com \
--cc=ehabkost@redhat.com \
--cc=mark.burton@greensocs.com \
--cc=mirela.grujic@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).