As a related note, is anyone seriously using/developing the mainline QEMU sources on/for Windows?<br><br>If so, what is the recommended environment to do so? I&#39;m currently using cygwin to generate<br>mingw-linked binaries (which dont require cygwin.dll at runtime), but I can think of other ways<br>
to generate these:<br><br>- using MSYS + mingw<br>- using mingw and the Windows command line<br>- using Linux and the linux-mingw32 toolchain<br><br>Finally, what is the best way to send patches to this list?. I notice that many patches are also sent<br>
directly to various developers, and that they tend to get reviewed/accepted/rejected a tad more rapidly.<br><br>Is it ok to send patches as attachments ? or should they be sent with git-send-email instead?<br><br>By the way, I&#39;d be happy to regularly check the Windows mainline build if that can help.<br>
<br>I&#39;m also preparing a series of patches that fix several Windows-specific issues (most of them related<br>to this horrible thing they called Winsock...).<br><br>Thanks for your time.<br><br>- David<br><br><div class="gmail_quote">
On Wed, Jun 10, 2009 at 1:53 PM, David Turner <span dir="ltr">&lt;<a href="mailto:digit@google.com">digit@google.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>Feature detection didn&#39;t work properly under cygwin because the OS_CFLAGS=-mno-cygwin</div><div>flags was not passed to the feature checks (which only used $ARCH_CFLAGS). The end</div><div>result being that features were detected against the mostly-Posix Cygwin headers,</div>


<div>while compilation happened against the Mingw headers which lack many headers like</div><div>&lt;sys/uio.h&gt;, &lt;fnmatch.h&gt; and others.</div><div><br></div><div>Also, an OS_LDFLAGS=-mno-cygwin was missing, resulting in a link-time error</div>


<div><br></div><div>Finally, three helper functions are introduced to simplify feature detection within</div><div>the configure script: check_compile, check_link and check_link_with_log. Feature</div><div>detection code was modified to use them instead of directly calling $cc with a really</div>


<div>long list of arguments.</div><div><br></div><div>Signed-off-by: digit &lt;<a href="mailto:digit@google.com" target="_blank">digit@google.com</a>&gt;</div><div>---</div><div> configure |   98 +++++++++++++++++++++++++++++++++++--------------------------</div>


<div> 1 files changed, 56 insertions(+), 42 deletions(-)</div><div><br></div><div>diff --git a/configure b/configure</div><div>index 89e7f53..e0191f0 100755</div><div>--- a/configure</div><div>+++ b/configure</div><div>@@ -73,7 +73,21 @@ cat &gt; $TMPC &lt;&lt;EOF</div>


<div> #endif</div><div> int main(void) { return 0; }</div><div> EOF</div><div>-  $cc $ARCH_CFLAGS -c -o $TMPO $TMPC &gt; /dev/null 2&gt; /dev/null</div><div>+  $cc $ARCH_CFLAGS -c -o $TMPO $TMPC ${OS_CFLAGS} &gt; /dev/null 2&gt; /dev/null</div>


<div>+}</div><div>+</div><div>+check_compile() {</div><div>+  $cc $ARCH_CFLAGS $OS_CFLAGS -c -o $TMPO $TMPC &gt; /dev/null 2&gt; /dev/null</div><div>+}</div><div>+</div><div>+check_link() {</div><div>+  $cc $ARCH_CFLAGS $OS_CFLAGS -o $TMPE $TMPC $* &gt; /dev/null 2&gt; /dev/null</div>


<div>+}</div><div>+</div><div>+check_link_with_log() {</div><div>+    TMPLOG=$1</div><div>+    shift</div><div>+    $cc $ARCH_CFLAGS $OS_CFLAGS -o $TMPE $TMPC $* &gt; $TMPLOG 2&gt;&amp;1</div><div> }</div><div> </div><div>


 if check_define __i386__ ; then</div><div>@@ -216,6 +230,7 @@ case $targetos in</div><div> CYGWIN*)</div><div> mingw32=&quot;yes&quot;</div><div> OS_CFLAGS=&quot;-mno-cygwin&quot;</div><div>+OS_LDFLAGS=&quot;-mno-cygwin&quot;</div>


<div> if [ &quot;$cpu&quot; = &quot;i386&quot; ] ; then</div><div>     kqemu=&quot;yes&quot;</div><div> fi</div><div>@@ -763,7 +778,7 @@ int main(int argc, char ** argv){</div><div> }</div><div> EOF</div><div> </div><div>


-if $cc $ARCH_CFLAGS -o $TMPE $TMPC &gt; /dev/null 2&gt; /dev/null ; then</div><div>+if check_link; then</div><div> $TMPE &amp;&amp; bigendian=&quot;yes&quot;</div><div> else</div><div> echo big/little test failed</div><div>


@@ -809,7 +824,7 @@ void foo()</div><div> }</div><div> EOF</div><div> </div><div>-if $cc $ARCH_CFLAGS -c -o $TMPO $TMPC &gt; /dev/null 2&gt; /dev/null ; then</div><div>+if check_compile; then</div><div>   :</div><div> else</div>


<div>    nptl=&quot;no&quot;</div><div>@@ -822,7 +837,7 @@ cat &gt; $TMPC &lt;&lt; EOF</div><div> #include &lt;zlib.h&gt;</div><div> int main(void) { zlibVersion(); return 0; }</div><div> EOF</div><div>-if $cc $ARCH_CFLAGS -o $TMPE ${OS_CFLAGS} $TMPC -lz &gt; /dev/null 2&gt; /dev/null ; then</div>


<div>+if check_link -lz; then</div><div>     :</div><div> else</div><div>     echo</div><div>@@ -841,7 +856,7 @@ cat &gt; $TMPC &lt;&lt;EOF</div><div> #include &lt;xs.h&gt;</div><div> int main(void) { xs_daemon_open; xc_interface_open; }</div>


<div> EOF</div><div>-   if $cc $ARCH_CFLAGS -c -o $TMPO $TMPC -lxenstore -lxenctrl 2&gt; /dev/null &gt; /dev/null ; then</div><div>+   if check_link -lxenstore -lxenctrl; then</div><div>       :</div><div>    else</div><div>


       xen=&quot;no&quot;</div><div>@@ -855,6 +870,8 @@ sdl_too_old=no</div><div> </div><div> if test &quot;$sdl&quot; = &quot;yes&quot; ; then</div><div>     sdl_config=&quot;sdl-config&quot;</div><div>+    sdl_cflags=`$sdl_config --cflags 2&gt; /dev/null`</div>


<div>+    sdl_ldflags=`$sdl_config --libs 2&gt; /dev/null`</div><div>     sdl=no</div><div>     sdl_static=no</div><div> </div><div>@@ -863,7 +880,7 @@ cat &gt; $TMPC &lt;&lt; EOF</div><div> #undef main /* We don&#39;t want SDL to override our main() */</div>


<div> int main( void ) { return SDL_Init (SDL_INIT_VIDEO); }</div><div> EOF</div><div>-    if $cc $ARCH_CFLAGS -o $TMPE ${OS_CFLAGS} `$sdl_config --cflags 2&gt; /dev/null` $TMPC `$sdl_config --libs 2&gt; /dev/null` &gt; $TMPSDLLOG 2&gt;&amp;1 ; then</div>


<div>+    if check_link_with_log $TMPSDLLOG $sdl_cflags $sdl_ldflags; then</div><div>         _sdlversion=`$sdl_config --version | sed &#39;s/[^0-9]//g&#39;`</div><div>         if test &quot;$_sdlversion&quot; -lt 121 ; then</div>


<div>             sdl_too_old=yes</div><div>@@ -882,7 +899,7 @@ EOF</div><div>                 sdl_static_libs=&quot;$sdl_static_libs `aalib-config --static-libs`&quot;</div><div>             fi</div><div> </div><div>-            if $cc -o $TMPE ${OS_CFLAGS} `$sdl_config --cflags 2&gt; /dev/null` $TMPC $sdl_static_libs &gt; /dev/null 2&gt; /dev/null; then</div>


<div>+            if check_link `$sdl_config --cflags 2&gt; /dev/null` $sdl_static_libs; then</div><div>                 sdl_static=yes</div><div>             fi</div><div>         fi # static link</div><div>@@ -905,8 +922,8 @@ cat &gt; $TMPC &lt;&lt;EOF</div>


<div> #endif</div><div> int main(void) { return 0; }</div><div> EOF</div><div>-    if $cc $ARCH_CFLAGS -o $TMPE ${OS_CFLAGS} `$sdl_config --cflags 2&gt; /dev/null` $TMPC `$sdl_config --libs 2&gt; /dev/null` &gt; /dev/null 2&gt;&amp;1 ; then</div>


<div>-<span style="white-space: pre;">	</span>sdl_x11=&quot;yes&quot;</div><div>+    if check_link $sdl_cflags $sdl_ldflags; then</div><div>+        sdl_x11=&quot;yes&quot;</div><div>     fi</div><div>
 fi</div><div> </div><div>@@ -919,11 +936,10 @@ int main(void) { gnutls_session_t s; gnutls_init(&amp;s, GNUTLS_SERVER); return 0; }</div><div> EOF</div><div>     vnc_tls_cflags=`pkg-config --cflags gnutls 2&gt; /dev/null`</div>


<div>     vnc_tls_libs=`pkg-config --libs gnutls 2&gt; /dev/null`</div><div>-    if $cc $ARCH_CFLAGS -o $TMPE ${OS_CFLAGS} $vnc_tls_cflags $TMPC \</div><div>-           $vnc_tls_libs &gt; /dev/null 2&gt; /dev/null ; then</div>


<div>-<span style="white-space: pre;">	</span>:</div><div>+    if check_link $vnc_tls_cflags $vnc_tls_libs; then</div><div>+        :</div><div>     else</div><div>-<span style="white-space: pre;">	</span>vnc_tls=&quot;no&quot;</div>


<div>+        vnc_tls=&quot;no&quot;</div><div>     fi</div><div> fi</div><div> </div><div>@@ -938,11 +954,10 @@ EOF</div><div>     # Assuming Cyrus-SASL installed in /usr prefix</div><div>     vnc_sasl_cflags=&quot;&quot;</div>


<div>     vnc_sasl_libs=&quot;-lsasl2&quot;</div><div>-    if $cc $ARCH_CFLAGS -o $TMPE ${OS_CFLAGS} $vnc_sasl_cflags $TMPC \</div><div>-           $vnc_sasl_libs 2&gt; /dev/null &gt; /dev/null ; then</div><div>-<span style="white-space: pre;">	</span>:</div>


<div>+    if check_link $vnc_sasl_cflags $vnc_sasl_libs; then</div><div>+        :</div><div>     else</div><div>-<span style="white-space: pre;">	</span>vnc_sasl=&quot;no&quot;</div><div>+        vnc_sasl=&quot;no&quot;</div>


<div>     fi</div><div> fi</div><div> </div><div>@@ -957,7 +972,7 @@ int main(void)</div><div>     return 0;</div><div> }</div><div> EOF</div><div>-if $cc $ARCH_CFLAGS -o $TMPE $TMPC &gt; /dev/null 2&gt; /dev/null ; then</div>


<div>+if check_link; then</div><div>    fnmatch=&quot;yes&quot;</div><div> fi</div><div> </div><div>@@ -973,7 +988,7 @@ int main(void)</div><div>     return 0;</div><div> }</div><div> EOF</div><div>-    if $cc $ARCH_CFLAGS -o $TMPE $TMPC -lvdeplug &gt; /dev/null 2&gt; /dev/null ; then</div>


<div>+    if check_link -lvdeplug; then</div><div>         :</div><div>     else</div><div>         vde=&quot;no&quot;</div><div>@@ -994,7 +1009,7 @@ audio_drv_probe()</div><div> #include &lt;$hdr&gt;</div><div> int main(void) { $exp }</div>


<div> EOF</div><div>-    if $cc $ARCH_CFLAGS $cfl -o $TMPE $TMPC $lib &gt; /dev/null 2&gt; /dev/null ; then</div><div>+    if check_link $cfl $lib; then</div><div>         :</div><div>     else</div><div>         echo</div>


<div>@@ -1058,8 +1073,8 @@ cat &gt; $TMPC &lt;&lt; EOF</div><div> #include &lt;brlapi.h&gt;</div><div> int main( void ) { return brlapi__openConnection (NULL, NULL, NULL); }</div><div> EOF</div><div>-    if $cc ${ARCH_CFLAGS} -o $TMPE ${OS_CFLAGS} $TMPC -lbrlapi &gt; /dev/null 2&gt; /dev/null ; then</div>


<div>-<span style="white-space: pre;">	</span>    brlapi=yes</div><div>+    if check_link -lbrlapi; then</div><div>+        brlapi=yes</div><div>     fi # brlapi compile test</div><div> fi # -z $brlapi</div>
<div> </div><div>@@ -1075,7 +1090,7 @@ if test &quot;$curses&quot; = &quot;yes&quot; ; then</div><div> #endif</div><div> int main(void) { resize_term(0, 0); return curses_version(); }</div><div> EOF</div><div>-  if $cc $ARCH_CFLAGS -o $TMPE $TMPC -lcurses &gt; /dev/null 2&gt; /dev/null ; then</div>


<div>+  if check_link -lcurses; then</div><div>     curses=yes</div><div>   fi</div><div> fi # test &quot;$curses&quot;</div><div>@@ -1089,8 +1104,9 @@ if test &quot;$curl&quot; = &quot;yes&quot; ; then</div><div> #include &lt;curl/curl.h&gt;</div>


<div> int main(void) { return curl_easy_init(); }</div><div> EOF</div><div>+  curl_cflags=`curl-cflags --cflags 2&gt;/dev/null`</div><div>   curl_libs=`curl-config --libs 2&gt;/dev/null`</div><div>- if $cc $ARCH_CFLAGS $curl_libs -o $TMPE $TMPC &gt; /dev/null 2&gt; /dev/null ; then</div>


<div>+ if check_link $curl_cflags $curl_libs; then</div><div>     curl=yes</div><div>   fi</div><div> fi # test &quot;$curl&quot;</div><div>@@ -1107,8 +1123,7 @@ int main(void) { return bt_error(0); }</div><div> EOF</div>


<div>   bluez_cflags=`pkg-config --cflags bluez 2&gt; /dev/null`</div><div>   bluez_libs=`pkg-config --libs bluez 2&gt; /dev/null`</div><div>-  if $cc $ARCH_CFLAGS -o $TMPE ${OS_CFLAGS} $bluez_cflags $TMPC \</div><div>-      $bluez_libs &gt; /dev/null 2&gt; /dev/null ; then</div>


<div>+  if check_link $bluez_cflags $bluez_libs; then</div><div>     :</div><div>   else</div><div>     bluez=&quot;no&quot;</div><div>@@ -1139,24 +1154,23 @@ EOF</div><div>       if test \( &quot;$cpu&quot; = &quot;i386&quot; -o &quot;$cpu&quot; = &quot;x86_64&quot; \) \</div>


<div>          -a -d &quot;$kerneldir/arch/x86/include&quot; ; then</div><div>             kvm_cflags=&quot;$kvm_cflags -I$kerneldir/arch/x86/include&quot;</div><div>-<span style="white-space: pre;">	</span>elif test &quot;$cpu&quot; = &quot;ppc&quot; -a -d &quot;$kerneldir/arch/powerpc/include&quot; ; then</div>


<div>-<span style="white-space: pre;">	</span>    kvm_cflags=&quot;$kvm_cflags -I$kerneldir/arch/powerpc/include&quot;</div><div>+    elif test &quot;$cpu&quot; = &quot;ppc&quot; -a -d &quot;$kerneldir/arch/powerpc/include&quot; ; then</div>


<div>+        kvm_cflags=&quot;$kvm_cflags -I$kerneldir/arch/powerpc/include&quot;</div><div>         elif test -d &quot;$kerneldir/arch/$cpu/include&quot; ; then</div><div>             kvm_cflags=&quot;$kvm_cflags -I$kerneldir/arch/$cpu/include&quot;</div>


<div>       fi</div><div>   else</div><div>       kvm_cflags=&quot;&quot;</div><div>   fi</div><div>-  if $cc $ARCH_CFLAGS -o $TMPE ${OS_CFLAGS} $kvm_cflags $TMPC \</div><div>-      &gt; /dev/null 2&gt;/dev/null ; then</div>


<div>+  if check_link $kvm_cflags; then</div><div>     :</div><div>   else</div><div>     kvm=&quot;no&quot;;</div><div>     if [ -x &quot;`which awk 2&gt;/dev/null`&quot; ] &amp;&amp; \</div><div>        [ -x &quot;`which grep 2&gt;/dev/null`&quot; ]; then</div>


<div>       kvmerr=`LANG=C $cc $ARCH_CFLAGS -o $TMPE ${OS_CFLAGS} $kvm_cflags $TMPC 2&gt;&amp;1 \</div><div>-<span style="white-space: pre;">	</span>| grep &quot;error: &quot; \</div><div>-<span style="white-space: pre;">	</span>| awk -F &quot;error: &quot; &#39;{if (NR&gt;1) printf(&quot;, &quot;); printf(&quot;%s&quot;,$2);}&#39;`</div>


<div>+        | grep &quot;error: &quot; \</div><div>+        | awk -F &quot;error: &quot; &#39;{if (NR&gt;1) printf(&quot;, &quot;); printf(&quot;%s&quot;,$2);}&#39;`</div><div>       if test &quot;$kvmerr&quot; != &quot;&quot; ; then</div>


<div>         kvm=&quot;no - (${kvmerr})\n\</div><div>     NOTE: To enable KVM support, update your kernel to 2.6.29+ or install \</div><div>@@ -1178,7 +1192,7 @@ cat &gt; $TMPC &lt;&lt; EOF</div><div> int main(void) { pthread_create(0,0,0,0); return 0; }</div>


<div> EOF</div><div>   for pthread_lib in $PTHREADLIBS_LIST; do</div><div>-    if $cc $ARCH_CFLAGS -o $TMPE $TMPC $pthread_lib 2&gt; /dev/null &gt; /dev/null ; then</div><div>+    if check_link $pthread_lib; then</div><div>


       pthread=yes</div><div>       PTHREADLIBS=&quot;$pthread_lib&quot;</div><div>       break</div><div>@@ -1200,7 +1214,7 @@ cat &gt; $TMPC &lt;&lt;EOF</div><div> int main(void) { struct iovec iov; return 0; }</div><div>


 EOF</div><div> iovec=no</div><div>-if $cc $ARCH_CFLAGS -o $TMPE $TMPC &gt; /dev/null 2&gt; /dev/null ; then</div><div>+if check_link; then</div><div>   iovec=yes</div><div> fi</div><div> </div><div>@@ -1213,7 +1227,7 @@ cat &gt; $TMPC &lt;&lt;EOF</div>


<div> int main(void) { preadv; }</div><div> EOF</div><div> preadv=no</div><div>-if $cc $ARCH_CFLAGS -o $TMPE $TMPC &gt; /dev/null 2&gt; /dev/null ; then</div><div>+if check_link; then</div><div>   preadv=yes</div><div> fi</div>


<div> </div><div>@@ -1224,7 +1238,7 @@ if test &quot;$fdt&quot; = &quot;yes&quot; ; then</div><div>     cat &gt; $TMPC &lt;&lt; EOF</div><div> int main(void) { return 0; }</div><div> EOF</div><div>-  if $cc $ARCH_CFLAGS -o $TMPE ${OS_CFLAGS} $TMPC -lfdt 2&gt; /dev/null &gt; /dev/null ; then</div>


<div>+  if check_link -lfdt; then</div><div>     fdt=yes</div><div>   fi</div><div> fi</div><div>@@ -1249,7 +1263,7 @@ main(void)</div><div> <span style="white-space: pre;">	</span>return (unlinkat(AT_FDCWD, &quot;nonexistent_file&quot;, 0));</div>


<div> }</div><div> EOF</div><div>-  if $cc $ARCH_CFLAGS -o $TMPE $TMPC 2&gt; /dev/null &gt; /dev/null ; then</div><div>+  if check_link; then</div><div>     atfile=yes</div><div>   fi</div><div> fi</div><div>@@ -1271,7 +1285,7 @@ main(void)</div>


<div> <span style="white-space: pre;">	</span>return inotify_init();</div><div> }</div><div> EOF</div><div>-  if $cc $ARCH_CFLAGS -o $TMPE $TMPC 2&gt; /dev/null &gt; /dev/null ; then</div><div>+  if check_link; then</div>

<div>     inotify=yes</div><div>   fi</div><div> fi</div><div>@@ -1291,9 +1305,9 @@ int main(void) { clockid_t id; return clock_gettime(id, NULL); }</div><div> EOF</div><div> </div><div> rt=no</div><div>-if $cc $ARCH_CFLAGS -o $TMPE $TMPC &gt; /dev/null 2&gt; /dev/null ; then</div>


<div>+if check_link; then</div><div>   :</div><div>-elif $cc $ARCH_CFLAGS -o $TMPE $TMPC -lrt &gt; /dev/null 2&gt; /dev/null ; then</div><div>+elif check_link -lrt; then</div><div>   rt=yes</div><div> fi</div><div> </div>


<div>@@ -1529,7 +1543,7 @@ else</div><div> #include &lt;byteswap.h&gt;</div><div> int main(void) { return bswap_32(0); }</div><div> EOF</div><div>-  if $cc $ARCH_CFLAGS -o $TMPE $TMPC &gt;/dev/null 2&gt; /dev/null ; then</div>


<div>+  if check_link; then</div><div>     echo &quot;#define HAVE_BYTESWAP_H 1&quot; &gt;&gt; $config_h</div><div>   fi</div><div>   cat &gt; $TMPC &lt;&lt; EOF</div><div>@@ -1538,7 +1552,7 @@ EOF</div><div> #include &lt;machine/bswap.h&gt;</div>


<div> int main(void) { return bswap32(0); }</div><div> EOF</div><div>-  if $cc $ARCH_CFLAGS -o $TMPE $TMPC &gt;/dev/null 2&gt; /dev/null ; then</div><div>+  if check_link; then</div><div>     echo &quot;#define HAVE_MACHINE_BSWAP_H 1&quot; &gt;&gt; $config_h</div>


<div>   fi</div><div> fi</div><div>-- </div><div>1.6.1.2</div><div><br></div><div><br></div><div><br></div>
</blockquote></div><br>