From: David Turner <digit@google.com>
To: Filip Navara <filip.navara@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH] Fix cygwin build and simplify feature detection in 'configure' script
Date: Thu, 11 Jun 2009 00:29:04 +0200 [thread overview]
Message-ID: <60cad3f0906101529v3cda666cqe9e31a2da3281f14@mail.gmail.com> (raw)
In-Reply-To: <5b31733c0906101517j543c3c14o1cf3ab2b491ca56d@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
On Thu, Jun 11, 2009 at 12:17 AM, Filip Navara <filip.navara@gmail.com>wrote:
> On Thu, Jun 11, 2009 at 12:09 AM, David Turner<digit@google.com> wrote:
> [snip]
> > Looking at configure through 'git blame' shows that the
> > "OS_CFLAGS=-mno-cygwin" line inside it is dated January 2007.
> > So I presume that no one is really testing the mainline sources on
> Windows
> > on a regular basis :-(
>
> Wrong presumption. :-) Using MSYS+MinGW here.
Mea culpa :-) Thanks for all the answers. As an after-thought, it seems the
patch could be
greatly simplified by just forcing the compiler to "gcc -mno-cygwin" if a
Cygwin environment
is detected.
I still think that the check_compile() / check_link() helpers are a good
ideas, but they are not
directly related to this issue, so they'd better be in a different patch.
I'll send these soon.
Thanks
>
> F.
>
[-- Attachment #2: Type: text/html, Size: 1485 bytes --]
next prev parent reply other threads:[~2009-06-10 22:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 11:53 [Qemu-devel] [PATCH] Fix cygwin build and simplify feature detection in 'configure' script David Turner
2009-06-10 20:52 ` [Qemu-devel] " David Turner
2009-06-10 21:40 ` malc
2009-06-10 22:09 ` David Turner
2009-06-10 22:17 ` Filip Navara
2009-06-10 22:29 ` David Turner [this message]
2009-06-10 23:32 ` David Turner
2009-06-11 0:53 ` David Turner
2009-06-10 22:19 ` malc
2009-06-12 2:26 ` Jamie Lokier
2009-06-12 9:55 ` Daniel P. Berrange
2009-06-12 10:36 ` Mark Cave-Ayland
2009-06-10 21:46 ` Consul
-- strict thread matches above, loose matches on Subject: below --
2009-06-10 22:02 Teemu Nätkinniemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60cad3f0906101529v3cda666cqe9e31a2da3281f14@mail.gmail.com \
--to=digit@google.com \
--cc=filip.navara@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).