From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MEWIC-00008b-HI for qemu-devel@nongnu.org; Wed, 10 Jun 2009 18:29:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MEWI8-00007P-O2 for qemu-devel@nongnu.org; Wed, 10 Jun 2009 18:29:12 -0400 Received: from [199.232.76.173] (port=34472 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MEWI8-00007I-He for qemu-devel@nongnu.org; Wed, 10 Jun 2009 18:29:08 -0400 Received: from smtp-out.google.com ([216.239.33.17]:9862) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MEWI7-0002dZ-Py for qemu-devel@nongnu.org; Wed, 10 Jun 2009 18:29:08 -0400 Received: from spaceape24.eur.corp.google.com (spaceape24.eur.corp.google.com [172.28.16.76]) by smtp-out.google.com with ESMTP id n5AMT6sX018250 for ; Wed, 10 Jun 2009 23:29:06 +0100 Received: from bwz3 (bwz3.prod.google.com [10.188.26.3]) by spaceape24.eur.corp.google.com with ESMTP id n5AMT4tq021694 for ; Wed, 10 Jun 2009 15:29:05 -0700 Received: by bwz3 with SMTP id 3so1153902bwz.33 for ; Wed, 10 Jun 2009 15:29:04 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <5b31733c0906101517j543c3c14o1cf3ab2b491ca56d@mail.gmail.com> References: <60cad3f0906100453y7a27dc2fhb1ea7d4c6f69e861@mail.gmail.com> <60cad3f0906101352o55dbb029i96989f52503e22a1@mail.gmail.com> <60cad3f0906101509l15154a82g8e1d5dc7375dce3@mail.gmail.com> <5b31733c0906101517j543c3c14o1cf3ab2b491ca56d@mail.gmail.com> Date: Thu, 11 Jun 2009 00:29:04 +0200 Message-ID: <60cad3f0906101529v3cda666cqe9e31a2da3281f14@mail.gmail.com> Subject: Re: [Qemu-devel] Re: [PATCH] Fix cygwin build and simplify feature detection in 'configure' script From: David Turner Content-Type: multipart/alternative; boundary=001636c5aa41b73f20046c060010 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Filip Navara Cc: qemu-devel@nongnu.org --001636c5aa41b73f20046c060010 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On Thu, Jun 11, 2009 at 12:17 AM, Filip Navara wrote: > On Thu, Jun 11, 2009 at 12:09 AM, David Turner wrote: > [snip] > > Looking at configure through 'git blame' shows that the > > "OS_CFLAGS=-mno-cygwin" line inside it is dated January 2007. > > So I presume that no one is really testing the mainline sources on > Windows > > on a regular basis :-( > > Wrong presumption. :-) Using MSYS+MinGW here. Mea culpa :-) Thanks for all the answers. As an after-thought, it seems the patch could be greatly simplified by just forcing the compiler to "gcc -mno-cygwin" if a Cygwin environment is detected. I still think that the check_compile() / check_link() helpers are a good ideas, but they are not directly related to this issue, so they'd better be in a different patch. I'll send these soon. Thanks > > F. > --001636c5aa41b73f20046c060010 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Thu, Jun 11, 2009 at 12:17 AM, Filip = Navara <fili= p.navara@gmail.com> wrote:
On Thu, Jun 11, 2009 at 12:09 AM, David Turner<digit@google.com> wrote:
[snip]
> Looking at configure through 'git blame' sho= ws that the
> "OS_CFLAGS=3D-mno-cygwin" line inside it is dated January 20= 07.
> So I presume that no one is really testing the mainline sources on Win= dows
> on a regular basis :-(

Wrong presumption. :-) Using MSYS+MinGW here.
=A0
Mea culpa :-) Thanks for all the answers. As an after-thought, it s= eems the patch could be
greatly simplified by just forcing the compiler = to "gcc -mno-cygwin" if a Cygwin environment
is detected.

I still think that the check_compile() / check_link() h= elpers are a good ideas, but they are not
directly related to this issue= , so they'd better be in a different patch.

I'll send these = soon.

Thanks
=A0

F.

--001636c5aa41b73f20046c060010--