qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Turner <digit@google.com>
To: Filip Navara <filip.navara@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH] Fix cygwin build and simplify feature detection in 'configure' script
Date: Thu, 11 Jun 2009 01:32:28 +0200	[thread overview]
Message-ID: <60cad3f0906101632g4e9e07dpb594479b12f4926a@mail.gmail.com> (raw)
In-Reply-To: <60cad3f0906101529v3cda666cqe9e31a2da3281f14@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 52 bytes --]

And here comes a new patch to fix the Cygwin build:

[-- Attachment #1.2: Type: text/html, Size: 98 bytes --]

[-- Attachment #2: 0001-Fix-the-cygwin-build-by-forcing-the-compiler-to-use.patch --]
[-- Type: application/octet-stream, Size: 963 bytes --]

From 3e7486b8562fde1c291515eae22bf67b484a775f Mon Sep 17 00:00:00 2001
From: David Turner <digit@google.com>
Date: Thu, 11 Jun 2009 01:26:45 +0200
Subject: [PATCH] Fix the cygwin build by forcing the compiler to use the -mno-cygwin flag.

Without this change, all feature tests were run against the nearly-Posix
Cygwin headers, generating a config-host.h file that didn't correspond to
the features of the Mingw headers used at build time.

This resulted in errors when trying to include things like <sys/uio.h>
or <fnmatch.h> which are not available from Mingw.

Signed-off-by: David Turner <digit@google.com>
---
 configure |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure b/configure
index 89e7f53..62ebd2e 100755
--- a/configure
+++ b/configure
@@ -215,7 +215,7 @@ fi
 case $targetos in
 CYGWIN*)
 mingw32="yes"
-OS_CFLAGS="-mno-cygwin"
+cc="$cc -mno-cygwin"
 if [ "$cpu" = "i386" ] ; then
     kqemu="yes"
 fi
-- 
1.6.1.2


  reply	other threads:[~2009-06-10 23:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-10 11:53 [Qemu-devel] [PATCH] Fix cygwin build and simplify feature detection in 'configure' script David Turner
2009-06-10 20:52 ` [Qemu-devel] " David Turner
2009-06-10 21:40   ` malc
2009-06-10 22:09     ` David Turner
2009-06-10 22:17       ` Filip Navara
2009-06-10 22:29         ` David Turner
2009-06-10 23:32           ` David Turner [this message]
2009-06-11  0:53             ` David Turner
2009-06-10 22:19       ` malc
2009-06-12  2:26         ` Jamie Lokier
2009-06-12  9:55           ` Daniel P. Berrange
2009-06-12 10:36             ` Mark Cave-Ayland
2009-06-10 21:46   ` Consul
  -- strict thread matches above, loose matches on Subject: below --
2009-06-10 22:02 Teemu Nätkinniemi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60cad3f0906101632g4e9e07dpb594479b12f4926a@mail.gmail.com \
    --to=digit@google.com \
    --cc=filip.navara@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).