From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MEYYM-0006In-0l for qemu-devel@nongnu.org; Wed, 10 Jun 2009 20:54:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MEYYH-0006IO-ED for qemu-devel@nongnu.org; Wed, 10 Jun 2009 20:54:01 -0400 Received: from [199.232.76.173] (port=45850 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MEYYH-0006IL-AE for qemu-devel@nongnu.org; Wed, 10 Jun 2009 20:53:57 -0400 Received: from smtp-out.google.com ([216.239.45.13]:22579) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MEYYE-0004dM-V9 for qemu-devel@nongnu.org; Wed, 10 Jun 2009 20:53:57 -0400 Received: from zps77.corp.google.com (zps77.corp.google.com [172.25.146.77]) by smtp-out.google.com with ESMTP id n5B0rlGv023491 for ; Wed, 10 Jun 2009 17:53:47 -0700 Received: from bwz7 (bwz7.prod.google.com [10.188.26.7]) by zps77.corp.google.com with ESMTP id n5B0rjR5027470 for ; Wed, 10 Jun 2009 17:53:46 -0700 Received: by bwz7 with SMTP id 7so1251943bwz.19 for ; Wed, 10 Jun 2009 17:53:44 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <60cad3f0906101632g4e9e07dpb594479b12f4926a@mail.gmail.com> References: <60cad3f0906100453y7a27dc2fhb1ea7d4c6f69e861@mail.gmail.com> <60cad3f0906101352o55dbb029i96989f52503e22a1@mail.gmail.com> <60cad3f0906101509l15154a82g8e1d5dc7375dce3@mail.gmail.com> <5b31733c0906101517j543c3c14o1cf3ab2b491ca56d@mail.gmail.com> <60cad3f0906101529v3cda666cqe9e31a2da3281f14@mail.gmail.com> <60cad3f0906101632g4e9e07dpb594479b12f4926a@mail.gmail.com> Date: Thu, 11 Jun 2009 02:53:44 +0200 Message-ID: <60cad3f0906101753g2c9ea999gfdbf4aa8a845b43b@mail.gmail.com> Subject: Re: [Qemu-devel] Re: [PATCH] Fix cygwin build and simplify feature detection in 'configure' script From: David Turner Content-Type: multipart/alternative; boundary=001636c5a82f1b2a26046c0806f3 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Filip Navara Cc: qemu-devel@nongnu.org --001636c5a82f1b2a26046c0806f3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit And here's the patch inlined: >>From 3e7486b8562fde1c291515eae22bf67b484a775f Mon Sep 17 00:00:00 2001 From: David Turner Date: Thu, 11 Jun 2009 01:26:45 +0200 Subject: [PATCH] Fix the cygwin build by forcing the compiler to use the -mno-cygwin flag. Without this change, all feature tests were run against the nearly-Posix Cygwin headers, generating a config-host.h file that didn't correspond to the features of the Mingw headers used at build time. This resulted in errors when trying to include things like or which are not available from Mingw. Signed-off-by: David Turner --- configure | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 89e7f53..62ebd2e 100755 --- a/configure +++ b/configure @@ -215,7 +215,7 @@ fi case $targetos in CYGWIN*) mingw32="yes" -OS_CFLAGS="-mno-cygwin" +cc="$cc -mno-cygwin" if [ "$cpu" = "i386" ] ; then kqemu="yes" fi -- 1.6.1.2 On Thu, Jun 11, 2009 at 1:32 AM, David Turner wrote: > And here comes a new patch to fix the Cygwin build: > --001636c5a82f1b2a26046c0806f3 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable And here's the patch inlined:

From 3e7486b8562fde1c291515eae22bf= 67b484a775f Mon Sep 17 00:00:00 2001
From: David Turner <digit@google.com>
Date: Thu, 11 Jun 2009 = 01:26:45 +0200
Subject: [PATCH] Fix the cygwin build by forcing the compiler to use the -m= no-cygwin flag.

Without this change, all feature tests were run agai= nst the nearly-Posix
Cygwin headers, generating a config-host.h file tha= t didn't correspond to
the features of the Mingw headers used at build time.

This resulted = in errors when trying to include things like <sys/uio.h>
or <fn= match.h> which are not available from Mingw.

Signed-off-by: David= Turner <digit@google.com> ---
=A0configure |=A0=A0=A0 2 +-
=A01 files changed, 1 insertions(+),= 1 deletions(-)

diff --git a/configure b/configure
index 89e7f53.= .62ebd2e 100755
--- a/configure
+++ b/configure
@@ -215,7 +215,7 @= @ fi
=A0case $targetos in
=A0CYGWIN*)
=A0mingw32=3D"yes"
-OS_= CFLAGS=3D"-mno-cygwin"
+cc=3D"$cc -mno-cygwin"
= =A0if [ "$cpu" =3D "i386" ] ; then
=A0=A0=A0=A0 kqem= u=3D"yes"
=A0fi
--
1.6.1.2



On Thu, Jun 11, 20= 09 at 1:32 AM, David Turner <digit@google.com> wrote:
And here comes a new patch to fix the Cygwin build:


--001636c5a82f1b2a26046c0806f3--