From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MEm32-0006Iw-Mq
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 11:18:36 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MEm2y-0006HE-6w
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 11:18:36 -0400
Received: from [199.232.76.173] (port=44867 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MEm2x-0006H9-UY
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 11:18:31 -0400
Received: from smtp-out.google.com ([216.239.33.17]:41894)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <digit@google.com>) id 1MEm2x-0006QV-8X
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 11:18:31 -0400
Received: from spaceape14.eur.corp.google.com (spaceape14.eur.corp.google.com
	[172.28.16.148]) by smtp-out.google.com with ESMTP id n5BFITmn021284
	for <qemu-devel@nongnu.org>; Thu, 11 Jun 2009 16:18:29 +0100
Received: from bwz4 (bwz4.prod.google.com [10.188.26.4])
	by spaceape14.eur.corp.google.com with ESMTP id n5BFISGm028976
	for <qemu-devel@nongnu.org>; Thu, 11 Jun 2009 08:18:28 -0700
Received: by bwz4 with SMTP id 4so398251bwz.41
	for <qemu-devel@nongnu.org>; Thu, 11 Jun 2009 08:18:28 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <200906111335.10116.paul@codesourcery.com>
References: <200906111335.10116.paul@codesourcery.com>
Date: Thu, 11 Jun 2009 17:18:27 +0200
Message-ID: <60cad3f0906110818x5893ce65w945a65568c2adf33@mail.gmail.com>
Subject: Re: [Qemu-devel] [RFC] Enable Werrror by default
From: David Turner <digit@google.com>
Content-Type: multipart/alternative; boundary=001636c5a537916ee8046c141a49
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

--001636c5a537916ee8046c141a49
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

On Thu, Jun 11, 2009 at 2:35 PM, Paul Brook <paul@codesourcery.com> wrote:

> I'd like to enable Werror by default. I've been using --enable-werror
> locally
> for a while now, and it's been extremely useful in picking up dumb errors
> (like the recent stellaris_enet.c breakage).
>
> Any objections?
>

I would recommend only making this the default for linux-x86 and
linux-x86_64 hosts,

My experience is that it is extremely unlikely that codes that compiles
warning-free on Linux
will do the same on Windows or Darwin. Even changing compiler versions can
result in
very surprising things.

--001636c5a537916ee8046c141a49
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<br><br><div class=3D"gmail_quote">On Thu, Jun 11, 2009 at 2:35 PM, Paul Br=
ook <span dir=3D"ltr">&lt;<a href=3D"mailto:paul@codesourcery.com">paul@cod=
esourcery.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" st=
yle=3D"border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex=
; padding-left: 1ex;">
I&#39;d like to enable Werror by default. I&#39;ve been using --enable-werr=
or locally<br>
for a while now, and it&#39;s been extremely useful in picking up dumb erro=
rs<br>
(like the recent stellaris_enet.c breakage).<br>
<br>
Any objections?<br>
</blockquote><div><br>I would recommend only making this the default for li=
nux-x86 and linux-x86_64 hosts,<br><br>My experience is that it is extremel=
y unlikely that codes that compiles warning-free on Linux<br>will do the sa=
me on Windows or Darwin. Even changing compiler versions can result in<br>
very surprising things.<br><br></div></div>

--001636c5a537916ee8046c141a49--