From: Paolo Bonzini <pbonzini@redhat.com>
To: Artem Pisarenko <artem.k.pisarenko@gmail.com>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
Fam Zheng <famz@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
"open list:Block I/O path" <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] Introduce attributes to qemu timer subsystem
Date: Tue, 16 Oct 2018 15:47:37 +0200 [thread overview]
Message-ID: <60d5705a-7a16-d3f5-d15c-79a32fa0fb18@redhat.com> (raw)
In-Reply-To: <09ea4617167b5cc88f2a65cf3248ffbdab25093c.1539694545.git.artem.k.pisarenko@gmail.com>
On 16/10/2018 15:03, Artem Pisarenko wrote:
> + if (!timer_list) {
> + timer_list = main_loop_tlg.tl[type];
> + }
> + timer_init_full(ts, timer_list, scale, attributes, cb, opaque);
Please move this "if" to timer_init_full, so that here you can just pass
timer_list. timer_init_full will then take a QEMUTimerListGroup* (NULL
defaults to &main_loop_tlg, aio_timer_new passes &ctx->tlg) and a
QEMUClockType instead of a QEMUTimerList*.
Paolo
next prev parent reply other threads:[~2018-10-16 13:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-14 14:55 [Qemu-devel] [PATCH 0/3] Introduce attributes for timers subsystem and remove QEMU_CLOCK_VIRTUAL_EXT clock type Artem Pisarenko
2018-10-14 14:55 ` [Qemu-devel] [PATCH 1/3] Revert some patches from recent series [PATCH v6] "Fixing record/replay and adding reverse debugging", which introduced new virtual clock type for use in external subsystems. These changes breaks desired behavior in non-record/replay usage scenarios Artem Pisarenko
2018-10-14 14:55 ` [Qemu-devel] [PATCH 2/3] Introduce attributes to qemu timer subsystem Artem Pisarenko
2018-10-15 8:39 ` Paolo Bonzini
2018-10-16 13:03 ` [Qemu-devel] [PATCH v2] " Artem Pisarenko
2018-10-16 13:47 ` Paolo Bonzini [this message]
2018-10-14 14:55 ` [Qemu-devel] [PATCH 3/3] Restores record/replay behavior related to special virtual clock processing for timers used in external subsystems Artem Pisarenko
2018-10-15 6:41 ` Artem Pisarenko
2018-10-15 8:51 ` Paolo Bonzini
2018-10-15 8:54 ` [Qemu-devel] [PATCH 0/3] Introduce attributes for timers subsystem and remove QEMU_CLOCK_VIRTUAL_EXT clock type Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60d5705a-7a16-d3f5-d15c-79a32fa0fb18@redhat.com \
--to=pbonzini@redhat.com \
--cc=artem.k.pisarenko@gmail.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).