From: Max Reitz <mreitz@redhat.com>
To: yuchenlin@synology.com, qemu-devel@nongnu.org
Cc: famz@redhat.com, kwolf@redhat.com, qemu-block@nongnu.org,
eblake@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3] vmdk: return ERROR when cluster sector is larger than vmdk limitation
Date: Mon, 26 Mar 2018 18:29:40 +0200 [thread overview]
Message-ID: <60f3297a-2bd8-c541-1a47-20d9f3393580@redhat.com> (raw)
In-Reply-To: <20180322133337.28024-1-yuchenlin@synology.com>
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
On 2018-03-22 14:33, yuchenlin@synology.com wrote:
> From: yuchenlin <yuchenlin@synology.com>
>
> VMDK has a hard limitation of extent size, which is due to the size of grain
> table entry is 32 bits. It means it can only point to a grain located at
> offset = 2^32. To avoid writing the user data beyond limitation and record a useless offset
> in grain table. We should return ERROR here.
>
> Signed-off-by: yuchenlin <yuchenlin@synology.com>
> ---
> v2->v3:
> - use (1ULL << 32) to clearly show the limitation of offset is 2^32.
>
> thanks
>
> block/vmdk.c | 6 ++++++
> 1 file changed, 6 insertions(+)
Thanks, applied to my block branch:
https://github.com/XanClic/qemu/commits/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
prev parent reply other threads:[~2018-03-26 16:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 13:33 [Qemu-devel] [PATCH v3] vmdk: return ERROR when cluster sector is larger than vmdk limitation yuchenlin
2018-03-26 16:29 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60f3297a-2bd8-c541-1a47-20d9f3393580@redhat.com \
--to=mreitz@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=yuchenlin@synology.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).