From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUxkN-0000PP-W1 for qemu-devel@nongnu.org; Wed, 03 Aug 2016 11:06:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUxkI-0003Vx-BN for qemu-devel@nongnu.org; Wed, 03 Aug 2016 11:06:15 -0400 References: <1470223294-3870-1-git-send-email-kwolf@redhat.com> <1470223294-3870-6-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <61028b67-c0bd-e7b6-783c-14ffde48462f@redhat.com> Date: Wed, 3 Aug 2016 17:06:00 +0200 MIME-Version: 1.0 In-Reply-To: <1470223294-3870-6-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="95JpO44EB1kVG8CHFISmVfsEA6LsTWdu8" Subject: Re: [Qemu-devel] [PATCH v5 05/11] block: Accept node-name for blockdev-snapshot-delete-internal-sync List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: eblake@redhat.com, berto@igalia.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --95JpO44EB1kVG8CHFISmVfsEA6LsTWdu8 From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: eblake@redhat.com, berto@igalia.com, qemu-devel@nongnu.org Message-ID: <61028b67-c0bd-e7b6-783c-14ffde48462f@redhat.com> Subject: Re: [PATCH v5 05/11] block: Accept node-name for blockdev-snapshot-delete-internal-sync References: <1470223294-3870-1-git-send-email-kwolf@redhat.com> <1470223294-3870-6-git-send-email-kwolf@redhat.com> In-Reply-To: <1470223294-3870-6-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 03.08.2016 13:21, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > blockdev-snapshot-delete-internal-sync to accept a node-name without > lifting the restriction that we're operating at a root node. >=20 > In case of an invalid device name, the command returns the GenericError= > error class now instead of DeviceNotFound, because this is what > qmp_get_root_bs() returns. >=20 > Signed-off-by: Kevin Wolf > Reviewed-by: Eric Blake > Reviewed-by: Alberto Garcia > --- > blockdev.c | 16 +++------------- > qapi/block.json | 5 +++-- > qmp-commands.hx | 2 +- > tests/qemu-iotests/057 | 2 +- > 4 files changed, 8 insertions(+), 17 deletions(-) Reviewed-by: Max Reitz --95JpO44EB1kVG8CHFISmVfsEA6LsTWdu8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEvBAEBCAAZBQJXoghYEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRA7sUIC6DisrRj2 CACJnHqtBrFIXcXDGsjpOCfSs8aNFukv7AO7jJi1+2ILYlceq2atTWQ+dzF6bnwc gAUwQKavQqMk9csvxl5lo3+sehHr+RKwvMwmYq+rZEcUTrKNaNfsUv/K2F2bKLQ6 FkbXp98s/5jNhOiHHmAn1bvtBVLyFPdU8DMjPLw2L/XxAJNDnJD+9lrqCmAWUI7W vjjlevFbvPleDBfV4pwd8HbupALepBw1uAc80fBG3EDlaFvaoil5qjMty+b6XcwT lUJWs1Xs2xHhfzODtnSEbWbfbVbQwnV+6CxuaGGgnW4SZSxUernQVG73RFwj9Afr ttsHbDOaeqCnNkJVD0gf4CVf =ETb3 -----END PGP SIGNATURE----- --95JpO44EB1kVG8CHFISmVfsEA6LsTWdu8--