From: Thomas Huth <thuth@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
zhang.zhanghailiang@huawei.com, qemu-trivial@nongnu.org,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, "Gan Qixin" <ganqixin@huawei.com>,
kuhn.chenqun@huawei.com
Subject: Re: Should bus-less devices default to .user_creatable = false? (was: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category)
Date: Wed, 18 Nov 2020 10:08:12 +0100 [thread overview]
Message-ID: <610fa3c0-0896-1ee7-76f3-9f2b97d54295@redhat.com> (raw)
In-Reply-To: <875z63oxq1.fsf_-_@dusky.pond.sub.org>
On 18/11/2020 09.50, Markus Armbruster wrote:
> Markus Armbruster <armbru@redhat.com> writes:
>
> [...]
>> qdev_device_add() looks like a bus-less device is usable if the machine
>> provides a hotplug handler for it. Commit 03fcbd9dc5 "qdev: Check for
>> the availability of a hotplug controller before adding a device" seems
>> to be pertinent.
>
> Nope. A hotplug handler is only required for hot plug (d'oh!), not for
> cold plug.
>
> I wonder whether bus-less devices should default to .user_creatable =
> false like sysbus devices, and for the same reasons.
>
> To actually *do* something, a physical device requires some connection
> to the rest of the world. Same for a virtual device (at least the ones
> that model physical devices).
I know at least two virtual devices that are bus-less and cold-pluggable:
hw/ppc/spapr_rng.c and hw/watchdog/wdt_diag288.c ... but we could certainly
mark them with user_creatable = true manually if we decide that bus-less
devices should be handled differently by default.
Thomas
next prev parent reply other threads:[~2020-11-18 9:09 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 18:48 [PATCH 00/13] Categorize some uncategorized devices Gan Qixin
2020-11-15 18:48 ` [PATCH 01/13] pc-dimm: put it into the 'storage' category Gan Qixin
2020-11-15 18:48 ` [PATCH 02/13] virtio-pmem: " Gan Qixin
2020-11-19 14:12 ` Pankaj Gupta
2020-12-04 7:24 ` Pankaj Gupta
2020-11-15 18:48 ` [PATCH 03/13] vmmouse: put it into the 'input' category Gan Qixin
2020-11-16 14:05 ` Philippe Mathieu-Daudé
2020-11-15 18:48 ` [PATCH 04/13] nvdimm: put it into the 'storage' category Gan Qixin
2020-11-15 18:48 ` [PATCH 05/13] mc146818rtc: put it into the 'misc' category Gan Qixin
2020-11-15 18:48 ` [PATCH 06/13] ipmi: put some ipmi devices into the correct category Gan Qixin
2020-11-15 18:48 ` [PATCH 07/13] tpm: put some tpm " Gan Qixin
2020-11-15 18:48 ` [PATCH 08/13] AMDVI-PCI: put it into the 'misc' category Gan Qixin
2020-11-15 18:48 ` [PATCH 09/13] u2f-passthru: put it into the 'usb' category Gan Qixin
2020-11-16 14:04 ` Philippe Mathieu-Daudé
2020-11-17 6:58 ` Gerd Hoffmann
2020-11-17 13:40 ` ganqixin
2020-11-17 13:37 ` ganqixin
2020-12-04 13:50 ` Philippe Mathieu-Daudé
2020-12-07 8:05 ` ganqixin
2020-12-07 8:52 ` Thomas Huth
2020-11-15 18:49 ` [PATCH 10/13] tosa-ssp: put it into the 'misc' category Gan Qixin
2020-11-15 18:49 ` [PATCH 11/13] spitz: put some Spitz-family devices into the correct category Gan Qixin
2020-11-15 18:49 ` [PATCH 12/13] SPI flash devices: put them into the 'storage' category Gan Qixin
2020-11-16 13:59 ` Philippe Mathieu-Daudé
2020-11-16 16:19 ` Alistair Francis
2020-11-15 18:49 ` [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category Gan Qixin
2020-11-16 13:25 ` Philippe Mathieu-Daudé
2020-11-16 13:31 ` Peter Maydell
2020-11-16 14:33 ` Thomas Huth
2020-11-16 14:30 ` Thomas Huth
2020-11-16 17:00 ` Markus Armbruster
2020-11-16 17:15 ` Peter Maydell
2020-11-17 5:41 ` Markus Armbruster
2020-11-17 11:08 ` Peter Maydell
2020-11-17 20:12 ` Thomas Huth
2020-11-18 8:41 ` Markus Armbruster
2020-11-18 8:50 ` Should bus-less devices default to .user_creatable = false? (was: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category) Markus Armbruster
2020-11-18 9:08 ` Thomas Huth [this message]
2020-11-17 14:02 ` [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category ganqixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=610fa3c0-0896-1ee7-76f3-9f2b97d54295@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=f4bug@amsat.org \
--cc=ganqixin@huawei.com \
--cc=kuhn.chenqun@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).