* [PATCH] scripts/checkpatch: Improve the check for authors mangled by the mailing list
@ 2021-02-16 7:15 Thomas Huth
2021-02-16 7:16 ` Philippe Mathieu-Daudé
2021-02-16 12:01 ` Christian Schoenebeck
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2021-02-16 7:15 UTC (permalink / raw)
To: qemu-devel, Paolo Bonzini
Cc: qemu-trivial, Philippe Mathieu-Daudé, Christian Schoenebeck
There were recently some patches on the list which had their "From:"
line mangled like this:
From: qemu_oss--- via <qemu-devel@nongnu.org>
Since our test in the checkpatch.pl script did not trigger here, the
patches finally also ended up in a pull request, with the wrong author
set. So let's improve the regular expression to also complain on
these new patterns, too.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index e47ad878d8..7f194c842b 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1499,7 +1499,7 @@ sub process {
$is_patch = 1;
}
- if ($line =~ /^Author: .*via Qemu-devel.*<qemu-devel\@nongnu.org>/) {
+ if ($line =~ /^(Author|From): .* via .*<qemu-devel\@nongnu.org>/) {
ERROR("Author email address is mangled by the mailing list\n" . $herecurr);
}
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scripts/checkpatch: Improve the check for authors mangled by the mailing list
2021-02-16 7:15 [PATCH] scripts/checkpatch: Improve the check for authors mangled by the mailing list Thomas Huth
@ 2021-02-16 7:16 ` Philippe Mathieu-Daudé
2021-02-16 12:01 ` Christian Schoenebeck
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-02-16 7:16 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Paolo Bonzini
Cc: qemu-trivial, Christian Schoenebeck
On 2/16/21 8:15 AM, Thomas Huth wrote:
> There were recently some patches on the list which had their "From:"
> line mangled like this:
>
> From: qemu_oss--- via <qemu-devel@nongnu.org>
>
> Since our test in the checkpatch.pl script did not trigger here, the
> patches finally also ended up in a pull request, with the wrong author
> set. So let's improve the regular expression to also complain on
> these new patterns, too.
:(
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scripts/checkpatch: Improve the check for authors mangled by the mailing list
2021-02-16 7:15 [PATCH] scripts/checkpatch: Improve the check for authors mangled by the mailing list Thomas Huth
2021-02-16 7:16 ` Philippe Mathieu-Daudé
@ 2021-02-16 12:01 ` Christian Schoenebeck
1 sibling, 0 replies; 3+ messages in thread
From: Christian Schoenebeck @ 2021-02-16 12:01 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, Paolo Bonzini, qemu-trivial,
Philippe Mathieu-Daudé
On Dienstag, 16. Februar 2021 08:15:12 CET Thomas Huth wrote:
> There were recently some patches on the list which had their "From:"
> line mangled like this:
>
> From: qemu_oss--- via <qemu-devel@nongnu.org>
>
> Since our test in the checkpatch.pl script did not trigger here, the
> patches finally also ended up in a pull request, with the wrong author
> set. So let's improve the regular expression to also complain on
> these new patterns, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index e47ad878d8..7f194c842b 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1499,7 +1499,7 @@ sub process {
> $is_patch = 1;
> }
>
> - if ($line =~ /^Author: .*via Qemu-devel.*<qemu-devel\@nongnu.org>/) {
> + if ($line =~ /^(Author|From): .* via .*<qemu-devel\@nongnu.org>/) {
> ERROR("Author email address is mangled by the mailing list\n" .
> $herecurr); }
I would probably generalize the pattern even a bit more:
if ($line =~ /^(Author|From): .*<qemu-devel\@nongnu.org>/) {
Because mailman's precise sender-rewrite prefix changed couple times. But for
now the change above will do as well of course.
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Best regards,
Christian Schoenebeck
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-16 12:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-16 7:15 [PATCH] scripts/checkpatch: Improve the check for authors mangled by the mailing list Thomas Huth
2021-02-16 7:16 ` Philippe Mathieu-Daudé
2021-02-16 12:01 ` Christian Schoenebeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).