Re: [PATCH] vl: fix leak of qdict_crumple return value

[Paolo Bonzini <pbonzini@redhat.com>]

On 08/07/21 11:05, Markus Armbruster wrote:
> Minimally invasive fix, but the result is a bit awkward.  Possibly
> neater:
> 
>         if (qobject_type(crumpled) == QTYPE_QLIST) {
>             error_setg(errp,
>                        "Lists cannot be at top level of a configuration section");
>         } else {
>             assert(qobject_type(crumpled) == QTYPE_QDICT);
>             qemu_record_config_group(group, qobject_to(QDict, crumpled),
>                                      false, errp);
>         }
>         qobject_unref(crumpled);

Even better:

     switch (qobject_type(crumpled)) {
     case QTYPE_QDICT:
         qemu_record_config_group(group, qobject_to(QDict, crumpled), false, errp);
         break;
     case QTYPE_QLIST:
         error_setg(errp, "Lists cannot be at top level of a configuration section");
         break;
     default:
         g_assert_unreachable();
     }

Paolo