qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: mark.cave-ayland@ilande.co.uk
Subject: Re: [PATCH v2 3/8] target/sparc: Drop inline markers from translate.c
Date: Wed, 28 Jun 2023 09:05:16 +0200	[thread overview]
Message-ID: <613cdd61-71af-0100-228b-0a59fa1af5ba@linaro.org> (raw)
In-Reply-To: <1a3fefd1-fb3a-1e38-8938-ff3de9cc4dc8@linaro.org>

On 6/27/23 10:58, Philippe Mathieu-Daudé wrote:
> On 21/6/23 20:06, Richard Henderson wrote:
>> Let the compiler decide about inlining.
> 
> Should we clean that automatically with scripts and forbid via
> checkpatch?

I'm sure there are some places that benefit from inline within C files.
And of course header files need them for unused function elimination.


r~



  reply	other threads:[~2023-06-28  7:06 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 18:05 [PATCH v2 0/8] target/sparc: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2023-06-21 18:06 ` [PATCH v2 1/8] target/sparc: Use tcg_gen_lookup_and_goto_ptr in gen_goto_tb Richard Henderson
2023-06-22  9:03   ` Philippe Mathieu-Daudé
2023-06-21 18:06 ` [PATCH v2 2/8] target/sparc: Fix npc comparison in sparc_tr_insn_start Richard Henderson
2023-06-27  9:11   ` Philippe Mathieu-Daudé
2023-06-21 18:06 ` [PATCH v2 3/8] target/sparc: Drop inline markers from translate.c Richard Henderson
2023-06-27  8:58   ` Philippe Mathieu-Daudé
2023-06-28  7:05     ` Richard Henderson [this message]
2023-06-21 18:06 ` [PATCH v2 4/8] target/sparc: Introduce DYNAMIC_PC_LOOKUP Richard Henderson
2023-06-27  9:08   ` Philippe Mathieu-Daudé
2023-06-21 18:06 ` [PATCH v2 5/8] target/sparc: Use DYNAMIC_PC_LOOKUP for conditional branches Richard Henderson
2023-06-27  9:09   ` Philippe Mathieu-Daudé
2023-06-21 18:06 ` [PATCH v2 6/8] target/sparc: Use DYNAMIC_PC_LOOKUP for JMPL Richard Henderson
2023-06-27  9:12   ` Philippe Mathieu-Daudé
2023-06-21 18:06 ` [PATCH v2 7/8] target/sparc: Use DYNAMIC_PC_LOOKUP for v9 RETURN Richard Henderson
2023-06-27  9:10   ` Philippe Mathieu-Daudé
2023-06-21 18:06 ` [PATCH v2 8/8] target/sparc: Use tcg_gen_lookup_and_goto_ptr for v9 WRASI Richard Henderson
2023-06-22  9:04   ` Philippe Mathieu-Daudé
2023-06-22 12:26 ` [PATCH v2 0/8] target/sparc: Use tcg_gen_lookup_and_goto_ptr Mark Cave-Ayland
2023-06-27  6:46   ` Mark Cave-Ayland
2023-06-27  9:37     ` Philippe Mathieu-Daudé
2023-06-27 10:12       ` Richard Henderson
2023-06-27 11:19       ` Mark Cave-Ayland
2023-06-27 11:57         ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=613cdd61-71af-0100-228b-0a59fa1af5ba@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).