From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH 1/4] linux-user/mips64: Restore setup_frame() for o32 ABI
Date: Thu, 17 Dec 2020 11:18:30 +0100 [thread overview]
Message-ID: <61685704-c22e-b1ee-cf7d-5f92a397d2b9@vivier.eu> (raw)
In-Reply-To: <20201119161710.1985083-2-f4bug@amsat.org>
Le 19/11/2020 à 17:17, Philippe Mathieu-Daudé a écrit :
> 64-bit MIPS targets lost setup_frame() during the refactor in commit
> 8949bef18b9. Restore it declaring TARGET_ARCH_HAS_SETUP_FRAME, to be
> able to build the o32 ABI target.
>
> Fixes: 8949bef18b9 ("linux-user: move mips/mips64 signal.c parts to mips directory")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> linux-user/mips64/target_signal.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/linux-user/mips64/target_signal.h b/linux-user/mips64/target_signal.h
> index 799f7a668cd..f1f0ed7f706 100644
> --- a/linux-user/mips64/target_signal.h
> +++ b/linux-user/mips64/target_signal.h
> @@ -67,4 +67,8 @@ typedef struct target_sigaltstack {
> #define TARGET_MINSIGSTKSZ 2048
> #define TARGET_SIGSTKSZ 8192
>
> +#if defined(TARGET_ABI_MIPSO32)
> +/* compare linux/arch/mips/kernel/signal.c:setup_frame() */
> +#define TARGET_ARCH_HAS_SETUP_FRAME
> +#endif
> #endif /* MIPS64_TARGET_SIGNAL_H */
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2020-12-17 10:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 16:17 [PATCH 0/4] linux-user: Support o32 ABI with 64-bit MIPS CPUs Philippe Mathieu-Daudé
2020-11-19 16:17 ` [PATCH 1/4] linux-user/mips64: Restore setup_frame() for o32 ABI Philippe Mathieu-Daudé
2020-11-19 23:07 ` Richard Henderson
2020-12-17 10:18 ` Laurent Vivier [this message]
2021-02-11 21:33 ` Laurent Vivier
2020-11-19 16:17 ` [PATCH 2/4] linux-user/mips64: Support o32 ABI syscalls Philippe Mathieu-Daudé
2020-11-19 23:08 ` Richard Henderson
2020-11-19 23:09 ` Richard Henderson
2020-12-17 10:40 ` Laurent Vivier
2020-12-17 16:10 ` Philippe Mathieu-Daudé
2020-12-17 17:20 ` Fredrik Noring
2020-12-17 20:14 ` Laurent Vivier
2021-02-11 21:33 ` Laurent Vivier
2020-11-19 16:17 ` [PATCH 3/4] default-configs: Support o32 ABI with 64-bit MIPS CPUs Philippe Mathieu-Daudé
2020-11-19 16:45 ` Maciej W. Rozycki
2020-11-19 17:13 ` Philippe Mathieu-Daudé
2020-12-12 8:29 ` Fredrik Noring
2020-12-12 17:03 ` Fredrik Noring
2020-11-19 16:17 ` [PATCH 4/4] RFC qemu-binfmt-conf.sh: Add MIPS64 o32 ABI Philippe Mathieu-Daudé
2020-11-19 23:14 ` Richard Henderson
2020-11-19 16:27 ` [PATCH 0/4] linux-user: Support o32 ABI with 64-bit MIPS CPUs no-reply
2020-12-13 15:14 ` Philippe Mathieu-Daudé
2021-02-09 18:31 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61685704-c22e-b1ee-cf7d-5f92a397d2b9@vivier.eu \
--to=laurent@vivier.eu \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).