From: "Cédric Le Goater" <clg@redhat.com>
To: "Liu, Jing2" <jing2.liu@intel.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
"Chatre, Reinette" <reinette.chatre@intel.com>
Subject: Re: [PATCH RFC v1 1/3] vfio/pci: detect the support of dynamic MSI-X allocation
Date: Mon, 31 Jul 2023 09:25:39 +0200 [thread overview]
Message-ID: <6187ba85-5082-02e9-159b-1abb6b6371e9@redhat.com> (raw)
In-Reply-To: <DS0PR11MB8114EDC8682BC265FFFA34C8A905A@DS0PR11MB8114.namprd11.prod.outlook.com>
On 7/31/23 05:57, Liu, Jing2 wrote:
> Hi C.
>
>> On July 28, 2023 4:44 PM, Cédric Le Goater <clg@redhat.com> wrote:
>>
>> [ ... ]
>>
>>> Sorry I didn't quite understand "info.flags be tested against
>> VFIO_IRQ_INFO_NORESIZE".
>>> I saw kernel < 6.4 simply added NORESIZE to info.flags and latest kernel adds
>> if has_dyn_msix.
>>> Would you please kindly describe more on your point?
>>
>> I was trying to find the conditions to detect safely that the kernel didn't have
>> dynamic MSI-X support. Testing VFIO_IRQ_INFO_NORESIZE seems enough.
>>
> Oh, I see.
>
>>>> In that case, QEMU should report an error and the trace event is not
>> needed.
>>>
>>> I replied an email with new error handling draft code based on my
>>> understanding, which reports the error and need no trace. Could you please
>> help review if that is what we want?
>>
>> yes. It looked good. Please send a v1 !
>
> Thanks for reviewing that. I guess you mean v2 for next version 😊
Well, if you remove the RFC status, I think you should, this would
still be a v1.
Thanks,
C.
next prev parent reply other threads:[~2023-07-31 7:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 7:24 [PATCH RFC v1 0/3] Support dynamic MSI-X allocation Jing Liu
2023-07-27 7:24 ` [PATCH RFC v1 1/3] vfio/pci: detect the support of " Jing Liu
2023-07-27 16:58 ` Cédric Le Goater
2023-07-28 8:34 ` Liu, Jing2
2023-07-28 8:43 ` Cédric Le Goater
2023-07-31 3:57 ` Liu, Jing2
2023-07-31 7:25 ` Cédric Le Goater [this message]
2023-07-31 8:40 ` Liu, Jing2
2023-07-27 17:24 ` Alex Williamson
2023-07-28 8:09 ` Liu, Jing2
2023-07-28 8:27 ` Cédric Le Goater
2023-07-28 15:41 ` Alex Williamson
2023-07-28 15:51 ` Cédric Le Goater
2023-07-31 3:51 ` Liu, Jing2
2023-07-27 7:24 ` [PATCH RFC v1 2/3] vfio/pci: enable vector on " Jing Liu
2023-07-27 17:07 ` Cédric Le Goater
2023-07-27 17:25 ` Alex Williamson
2023-07-31 7:17 ` Liu, Jing2
2023-07-27 7:24 ` [PATCH RFC v1 3/3] vfio/pci: dynamic MSI-X allocation in interrupt restoring Jing Liu
2023-07-27 17:24 ` Alex Williamson
2023-08-01 7:45 ` Liu, Jing2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6187ba85-5082-02e9-159b-1abb6b6371e9@redhat.com \
--to=clg@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=jing2.liu@intel.com \
--cc=kevin.tian@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).