From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A1CEC433E0 for ; Thu, 2 Jul 2020 10:40:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A5EE2073E for ; Thu, 2 Jul 2020 10:40:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Aj2t1WTI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A5EE2073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqweF-00037B-G3 for qemu-devel@archiver.kernel.org; Thu, 02 Jul 2020 06:40:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jqwdb-0002gZ-1h for qemu-devel@nongnu.org; Thu, 02 Jul 2020 06:40:15 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:46256 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jqwdZ-0006Jo-Cd for qemu-devel@nongnu.org; Thu, 02 Jul 2020 06:40:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593686411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JjnmKmfN5O+bqpmdizHhly71CAMwHeiv7QxtH162G80=; b=Aj2t1WTI/z942ZnCC1lZqpUqTUYveEKEJG2wAfU48PvgZFcHHQOQW7APxa84yMq9LikwXb vRzWEuuJdYMBLqy8vBsD3tUS3gzLxymUvliXsu5pTUeW9dUrLYsigGUg4YlU79z3AdXvTw cFXDuEYFJo0K/p48cb52iGMI3sw9yec= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-411-8svmUhRyOj6exsZNy8SlWA-1; Thu, 02 Jul 2020 06:40:08 -0400 X-MC-Unique: 8svmUhRyOj6exsZNy8SlWA-1 Received: by mail-ej1-f70.google.com with SMTP id h26so20324948ejb.5 for ; Thu, 02 Jul 2020 03:40:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=JjnmKmfN5O+bqpmdizHhly71CAMwHeiv7QxtH162G80=; b=iaZ2Bs1tkLEYGepYHA3emSdMErt6HfzEkCTyEJgPualti5ZSFrwLum5K/lJ3HiOHyI vQJdGsrKIjzB+UURwQ/QJuu19uGCVdfkpc61h0yXRMrKPG+nRhYVfu7nfL/WiFaTUgnS zUCUioKJy35UZ9fvsbTWJ87cD6kagdUQl4gJkZ9t/+TPDuUmaNnf0b0nowCFoXwz29BL CLp8Iz8L5JJwQB+cYwIybg+J4Rawe9uYIfc8mRrogG8zfXsV39Az/B4tZ5R8J9zr1KtB FYhef+yMb48V9jKOoUuHGN8YMpwrc5HXGkOLF+grDjf658hIRDXGJ3L132zfcwGZkAde YiEw== X-Gm-Message-State: AOAM533VNlNB/aWvHUUSS8ChOgcMf9uUo6m0gXDd2bsNAqZNxJ3JwhP+ 3Ej5OavxLeG2pjlX6P75hEyFwOqbbVZc9pOG1SwEZZxZgdoflv1vEJ2qKN3TtTI5Tv6vYJzV0wG 9FN8018/hmP6PWcg= X-Received: by 2002:a17:906:2b9b:: with SMTP id m27mr15725449ejg.19.1593686407151; Thu, 02 Jul 2020 03:40:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwy6ZjPyeZfNlB4vCvCC/wbSESxDV0AM9Il01/4j1REyN0Mkv5y5bVU1IOo+wPDUW+ZLupt4A== X-Received: by 2002:a17:906:2b9b:: with SMTP id m27mr15725427ejg.19.1593686406924; Thu, 02 Jul 2020 03:40:06 -0700 (PDT) Received: from [192.168.1.37] (1.red-83-51-162.dynamicip.rima-tde.net. [83.51.162.1]) by smtp.gmail.com with ESMTPSA id bc23sm8773078edb.90.2020.07.02.03.40.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2020 03:40:06 -0700 (PDT) Subject: Re: [PATCH v2] cpus: Move CPU code from exec.c to cpus-common.c To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200702103816.13798-1-f4bug@amsat.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <618fa9c4-9b59-7e11-8b5f-2c65ff6e2ba7@redhat.com> Date: Thu, 2 Jul 2020 12:40:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200702103816.13798-1-f4bug@amsat.org> Content-Language: en-US Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/02 04:18:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , Paolo Bonzini , Richard Henderson , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/2/20 12:38 PM, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > This code was introduced with SMP support in commit 6a00d60127, > later commit 267f685b8b moved CPU list management to common code > but forgot this code. Move now and simplify ifdef'ry. > > Reviewed-by: Richard Henderson > Reviewed-by: Alex Bennée > Signed-off-by: Philippe Mathieu-Daudé > --- > cpus-common.c | 18 ++++++++++++++++++ > exec.c | 22 ---------------------- > 2 files changed, 18 insertions(+), 22 deletions(-) Oops wrong identity profile.