From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E17DCCFA18 for ; Tue, 11 Nov 2025 03:45:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vIfJH-0008Mr-Fs; Mon, 10 Nov 2025 22:44:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vIfJD-0008K2-Na for qemu-devel@nongnu.org; Mon, 10 Nov 2025 22:44:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vIfJC-0005rr-1G for qemu-devel@nongnu.org; Mon, 10 Nov 2025 22:44:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762832681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pm4JC7F7/iIv/XfExCDEOGMpFEMIENDZi2IMTYveMXc=; b=OvUrwHocqYP1zg/pX0p/i42oM2uaYyjf1346TZo5xGnfFMTZMSq5rrnsQGtvivCRSwrbO3 BULjeymUNgaduei0134yLobs+FTN1I0RylyFYZIGs79/8PXAuV0t2n2Ja3ERlzzyWRLRwO mpXTk2pNX+5kp+83ShKETBBJmm8qHcU= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-pdhXPimCM-iYamXsj_1_Eg-1; Mon, 10 Nov 2025 22:44:39 -0500 X-MC-Unique: pdhXPimCM-iYamXsj_1_Eg-1 X-Mimecast-MFC-AGG-ID: pdhXPimCM-iYamXsj_1_Eg_1762832679 Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7b0e73b0f52so8516219b3a.1 for ; Mon, 10 Nov 2025 19:44:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1762832679; x=1763437479; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Pm4JC7F7/iIv/XfExCDEOGMpFEMIENDZi2IMTYveMXc=; b=rAYjfbBdP1MwwsuS95hIM+vEjj5ia1jhEZ5j3MN2iiCBngXxSpLhDGA8rdDFleLwjK UdyAFBaUdvNg9eEZ4sB5fmSyPU9SwCunTkZp4lqSNUXsyPLALmBksEWL97mpZossPWQC +B/UW6PEhgvYkePOM8YtlgGYGxgy71DSv75w2FSjHkTmfv7Kcw2ziwNmBru2BOgfT73j bGnhj5+jlGhAyo8NwCy2xFxAk80Yrnzew2WqZqYgnKgUsOj0ipTRdFsRh2b7GMGPO+mN AmNoS52RdoG6QwW+eq+mvLn43wKBV9inFeUZKHy57W6SgBo7XWK3r0vkB/IHEMPuaM/j PGvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762832679; x=1763437479; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Pm4JC7F7/iIv/XfExCDEOGMpFEMIENDZi2IMTYveMXc=; b=B9JNhJ5sxU+5zRI5tZ7RZo0eayARx/gg86l4uBzkjx/l+QjjJCvqDXC83oh2AIn8/w W3M134EKbbZi3OfXybJSRNKBOpT5O2wcxWhuLWdh9x11xeeXPeGzqdoVG9cLS8Kl6+cA NQ/ahsKJqj+lrD2k1rrOD62fLFNh6cFvXE0HDzJdQ7B5OdEZ0kvf81Uz4sHCDStoZJGh ff/xq/oeKDRttQJQNivtFhc1vEDWFX/HXgmrOM4dXSN7ZmIXqFRXt1m1emjSHK4H+8ST 8G2lJJlfdOMwHwtNuM52abPCimX3qFTXHK/F3S0YzRNAVvgG3wN+SNXcCdp33g7+pcm/ mB0g== X-Gm-Message-State: AOJu0YzBNcoBAt3l+785JnCiiv7Vz4P4RbTQmcL8dMb5kc0eAKOS0wVf HY/x7T4OPBpjyfJd5UIkpd/uxKMf9bAL7XjC0VW4rKnWOSekgsdGEM9aw3klNhauVdthnJK9gMk 877jlmqmZHtjM5Hx8S3clHQ/w2Q971iLhCzXjWVmyYGDBtiJqzwkVDyhy X-Gm-Gg: ASbGncvLLhcd6UT08krM5wyyvGV4LvALtdu2kW8cLx7JS9RqrwL8M/HFhk3Muo/BJTR i+1L0A/Vme951pKpyPDrGLNwpKNxDnxeN7ubWlv04T3URyBDoizAtZHltXNF7NaUGavb2+zSzdO 7iqndwwuDXrcvQ9+IUAysahDPvP/0o6BGYQNKHIwS+LvwKfQUZgIehGzXUYvWLzKXpHVweZdgIu b+XCgDddNS7tyPmcY16Scms/ajWiAQXzD6OXWi3jV1QIQKKsiA3l2icdrXXfH4evlV0N4FFN49l 4tIWvxvIih979XCVn4rTRWS7C6e4cf85pjS2dB2DpbfkfSEPPz1uEz/txVphI7JJ3EGSe5vMIAn kiyAvA0ORUhPW9fdk8k4eZdRVvIMamCKxlk3N3xg= X-Received: by 2002:a05:6a00:2e84:b0:782:7052:5167 with SMTP id d2e1a72fcca58-7b225acce1bmr14344211b3a.6.1762832678720; Mon, 10 Nov 2025 19:44:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IE8jOzNraaYSZ0QChjKiUaaMmGZ2uUO6gQFhmQxWAKnnIn4VGztVGqSvresLZcEO4sUs7EEKA== X-Received: by 2002:a05:6a00:2e84:b0:782:7052:5167 with SMTP id d2e1a72fcca58-7b225acce1bmr14344183b3a.6.1762832678334; Mon, 10 Nov 2025 19:44:38 -0800 (PST) Received: from [192.168.68.51] (n175-34-62-5.mrk21.qld.optusnet.com.au. [175.34.62.5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b0ca1e7b19sm13313459b3a.32.2025.11.10.19.44.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Nov 2025 19:44:37 -0800 (PST) Message-ID: <6196ad85-9afc-4e87-a784-9bf0191c329f@redhat.com> Date: Tue, 11 Nov 2025 13:44:31 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/8] acpi/ghes: Extend acpi_ghes_memory_errors() to support multiple CPERs To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org Cc: qemu-devel@nongnu.org, jonathan.cameron@huawei.com, mchehab+huawei@kernel.org, gengdongjiu1@gmail.com, mst@redhat.com, imammedo@redhat.com, anisinha@redhat.com, peter.maydell@linaro.org, pbonzini@redhat.com, shan.gavin@gmail.com References: <20251105114453.2164073-1-gshan@redhat.com> <20251105114453.2164073-5-gshan@redhat.com> <7ae1ee01-5d3f-4afd-af9a-ba9bc62f3541@linaro.org> Content-Language: en-US From: Gavin Shan In-Reply-To: <7ae1ee01-5d3f-4afd-af9a-ba9bc62f3541@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=gshan@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Philippe, On 11/11/25 12:48 AM, Philippe Mathieu-Daudé wrote: > On 5/11/25 12:44, Gavin Shan wrote: >> In the situation where host and guest has 64KiB and 4KiB page sizes, >> one problematic host page affects 16 guest pages. we need to send 16 >> consective errors in this specific case. >> >> Extend acpi_ghes_memory_errors() to support multiple CPERs after the >> hunk of code to generate the GHES error status is pulled out from >> ghes_gen_err_data_uncorrectable_recoverable(). The status field of >> generic error status block is also updated accordingly if multiple >> error data entries are contained in the generic error status block. >> >> Signed-off-by: Gavin Shan >> --- >>   hw/acpi/ghes-stub.c    |  2 +- >>   hw/acpi/ghes.c         | 60 +++++++++++++++++++++++------------------- >>   include/hw/acpi/ghes.h |  2 +- >>   target/arm/kvm.c       |  4 ++- >>   4 files changed, 38 insertions(+), 30 deletions(-) > > >> diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c >> index a9c08e73c0..527b85c8d8 100644 >> --- a/hw/acpi/ghes.c >> +++ b/hw/acpi/ghes.c >> @@ -57,8 +57,12 @@ >>   /* The memory section CPER size, UEFI 2.6: N.2.5 Memory Error Section */ >>   #define ACPI_GHES_MEM_CPER_LENGTH           80 >> -/* Masks for block_status flags */ >> -#define ACPI_GEBS_UNCORRECTABLE         1 >> +/* Bits for block_status flags */ >> +#define ACPI_GEBS_UNCORRECTABLE           0 >> +#define ACPI_GEBS_CORRECTABLE             1 >> +#define ACPI_GEBS_MULTIPLE_UNCORRECTABLE  2 >> +#define ACPI_GEBS_MULTIPLE_CORRECTABLE    3 >> +#define ACPI_GEBS_ERROR_DATA_ENTRIES      4 > > Alternatively using "hw/registerfields.h" API: > >   ... >   FIELD(ACPI_GEBS, MULTIPLE_CORRECTABLE, 3, 1) >   FIELD(ACPI_GEBS, ERROR_DATA_ENTRIES, 4, 10) > > then use FIELD_DP32() to only set the correct bits. > Acked. It's a nice point and will do in next revision. Thanks, Gavin