From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Klaus Jensen <its@irrelevant.dk>, qemu-devel@nongnu.org
Cc: Keith Busch <kbusch@kernel.org>,
qemu-block@nongnu.org, Klaus Jensen <k.jensen@samsung.com>
Subject: Re: [PATCH v2 1/2] hw/nvme: fix incorrect use of errp/local_err
Date: Thu, 10 Nov 2022 10:59:02 +0100 [thread overview]
Message-ID: <61b53454-25eb-862e-dc10-d8528b26332e@linaro.org> (raw)
In-Reply-To: <20221110062335.18401-2-its@irrelevant.dk>
On 10/11/22 07:23, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Make nvme_check_constraints() return a bool and fix an invalid error
> propagation where the actual error is thrown away in favor of an unused
> local Error value.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
> hw/nvme/ctrl.c | 48 +++++++++++++++++++++++-------------------------
> 1 file changed, 23 insertions(+), 25 deletions(-)
> @@ -7586,7 +7585,6 @@ static void nvme_realize(PCIDevice *pci_dev, Error **errp)
> &pci_dev->qdev, n->parent_obj.qdev.id);
>
> if (nvme_init_subsys(n, errp)) {
Similarly nvme_init_subsys() could return a boolean.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> - error_propagate(errp, local_err);
> return;
> }
> nvme_init_state(n);
next prev parent reply other threads:[~2022-11-10 9:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 6:23 [PATCH v2 0/2] hw/nvme: errp fixes Klaus Jensen
2022-11-10 6:23 ` [PATCH v2 1/2] hw/nvme: fix incorrect use of errp/local_err Klaus Jensen
2022-11-10 9:59 ` Philippe Mathieu-Daudé [this message]
2022-11-10 22:02 ` Klaus Jensen
2022-11-10 10:03 ` Markus Armbruster
2022-11-10 6:23 ` [PATCH v2 2/2] hw/nvme: cleanup error reporting in nvme_init_pci() Klaus Jensen
2022-11-10 10:00 ` Markus Armbruster
2022-11-10 22:06 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61b53454-25eb-862e-dc10-d8528b26332e@linaro.org \
--to=philmd@linaro.org \
--cc=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).