From: Paul Durrant <Paul.Durrant@citrix.com>
To: Paul Durrant <Paul.Durrant@citrix.com>,
'Peter Maydell' <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Cc: Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [Qemu-devel] QEMU xen coverity issues
Date: Fri, 15 Feb 2019 16:20:22 +0000 [thread overview]
Message-ID: <61c2a38ace454e2d963dcdd89d53737d@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <596fc361faea408cabae8a5f41df2e41@AMSPEX02CL03.citrite.net>
> -----Original Message-----
[snip]
> >
> > (5) CID 1398649: resource leak in xen_block_drive_create():
> >
> > In hw/block/xen-block.c xen_block_drive_create() Coverity
> > complains that the call "driver_layer = qdict_new()" allocates
> > memory that's leaked because we don't save the pointer anywhere
> > but don't deallocate it before the end of the function either.
> > Coverity is not great at understanding our refcounting objects,
> > but this does look like either we're missing a qobject_unref()
> > or something should be keeping hold of the dictionary. Probably
> > best to ask a block layer expert.
>
> AFAICT nothing will consume the dictionary so it does appear that we're
> missing an unref here.
Testing proves me wrong... This one is a false positive.
Paul
next prev parent reply other threads:[~2019-02-15 16:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 18:29 [Qemu-devel] QEMU xen coverity issues Peter Maydell
2019-02-15 9:21 ` Paul Durrant
2019-02-15 15:36 ` Paul Durrant
2019-02-15 16:20 ` Paul Durrant [this message]
2019-02-18 10:09 ` Kevin Wolf
2019-02-18 10:28 ` Paul Durrant
2019-02-18 10:58 ` Kevin Wolf
2019-02-19 16:17 ` Paul Durrant
2019-02-19 16:34 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61c2a38ace454e2d963dcdd89d53737d@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).