From: Hanna Reitz <hreitz@redhat.com>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Vladimir Sementsov-Ogievskiy <v.sementsov-og@mail.ru>,
qemu-block@nongnu.org
Subject: Re: [RFC PATCH 8/8] block: remove all unused ->can_set_aio_ctx and ->set_aio_ctx callbacks
Date: Fri, 15 Jul 2022 16:34:14 +0200 [thread overview]
Message-ID: <61e119d7-9b70-8e72-4ebb-52aed545888a@redhat.com> (raw)
In-Reply-To: <20220712211911.1302836-9-eesposit@redhat.com>
On 12.07.22 23:19, Emanuele Giuseppe Esposito wrote:
> Together with all _can_set_ and _set_ APIs, as they are not needed
> anymore.
>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
> block.c | 196 -----------------------------
> block/block-backend.c | 33 -----
> blockjob.c | 35 ------
> include/block/block-global-state.h | 9 --
> include/block/block_int-common.h | 4 -
> 5 files changed, 277 deletions(-)
Looks good! I’d just like a follow-up commit that also drops
bdrv_try_set_aio_context(), so it’s all gone (I think that’s the final
remnant?).
Hanna
next prev parent reply other threads:[~2022-07-15 14:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 21:19 [RFC PATCH 0/8] Refactor bdrv_try_set_aio_context using transactions Emanuele Giuseppe Esposito
2022-07-12 21:19 ` [RFC PATCH 1/8] block.c: assert bs->aio_context is written under BQL and drains Emanuele Giuseppe Esposito
2022-07-14 14:03 ` Hanna Reitz
2022-07-12 21:19 ` [RFC PATCH 2/8] transactions: add tran_add_back Emanuele Giuseppe Esposito
2022-07-14 15:13 ` Hanna Reitz
2022-07-18 16:20 ` Paolo Bonzini
2022-07-20 13:36 ` Vladimir Sementsov-Ogievskiy
2022-07-12 21:19 ` [RFC PATCH 3/8] RFC: block: use transactions as a replacement of ->{can_}set_aio_context() Emanuele Giuseppe Esposito
2022-07-14 16:45 ` Hanna Reitz
2022-07-18 8:45 ` Emanuele Giuseppe Esposito
2022-07-18 9:09 ` Emanuele Giuseppe Esposito
2022-07-20 14:09 ` Vladimir Sementsov-Ogievskiy
2022-07-25 8:35 ` Emanuele Giuseppe Esposito
2022-07-12 21:19 ` [RFC PATCH 4/8] blockjob: implement .change_aio_ctx in child_job Emanuele Giuseppe Esposito
2022-07-15 11:14 ` Hanna Reitz
2022-07-12 21:19 ` [RFC PATCH 5/8] block: implement .change_aio_ctx in child_of_bds Emanuele Giuseppe Esposito
2022-07-15 11:17 ` Hanna Reitz
2022-07-12 21:19 ` [RFC PATCH 6/8] block-backend: implement .change_aio_ctx in child_root Emanuele Giuseppe Esposito
2022-07-15 11:34 ` Hanna Reitz
2022-07-12 21:19 ` [RFC PATCH 7/8] block: use the new _change_ API instead of _can_set_ and _set_ Emanuele Giuseppe Esposito
2022-07-15 13:32 ` Hanna Reitz
2022-07-18 16:30 ` Paolo Bonzini
2022-07-18 16:39 ` Paolo Bonzini
2022-07-19 9:57 ` Emanuele Giuseppe Esposito
2022-07-19 18:07 ` Paolo Bonzini
2022-07-20 11:47 ` Emanuele Giuseppe Esposito
2022-07-12 21:19 ` [RFC PATCH 8/8] block: remove all unused ->can_set_aio_ctx and ->set_aio_ctx callbacks Emanuele Giuseppe Esposito
2022-07-15 14:34 ` Hanna Reitz [this message]
2022-07-18 8:45 ` Emanuele Giuseppe Esposito
2022-07-18 14:39 ` Emanuele Giuseppe Esposito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61e119d7-9b70-8e72-4ebb-52aed545888a@redhat.com \
--to=hreitz@redhat.com \
--cc=eesposit@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=v.sementsov-og@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).