From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Sergio Andres Gomez Del Real" <sergio.g.delreal@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator
Date: Mon, 8 Jan 2018 11:15:45 -0600 [thread overview]
Message-ID: <61e82ebc-52c6-1023-1eea-6fa39775fdc5@redhat.com> (raw)
In-Reply-To: <1515431442-23795-1-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 864 bytes --]
On 01/08/2018 11:10 AM, Peter Maydell wrote:
> In commit c97d6d2cdf97ed we accidentally added code to configure
> that uses '==' for string equality testing. This is a bashism --
> the portable way to write this is '='.
>
> This fixes the "Unexpected operator error" complaint produced
> if the system /bin/sh is dash.
>
> Fixes: c97d6d2cdf97ed
> Reported-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> As an aside, it's annoying that this doesn't make configure fail;
> otherwise it wouldn't have got through my build tests.
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2018-01-08 17:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 17:10 [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator Peter Maydell
2018-01-08 17:15 ` Eric Blake [this message]
2018-01-08 17:16 ` Philippe Mathieu-Daudé
2018-01-08 21:01 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61e82ebc-52c6-1023-1eea-6fa39775fdc5@redhat.com \
--to=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sergio.g.delreal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).