From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20B76C433F5 for ; Thu, 11 Nov 2021 11:33:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C758261212 for ; Thu, 11 Nov 2021 11:33:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C758261212 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:59286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ml8Kq-0004UB-Ng for qemu-devel@archiver.kernel.org; Thu, 11 Nov 2021 06:33:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ml8J9-00015Y-1d for qemu-devel@nongnu.org; Thu, 11 Nov 2021 06:31:55 -0500 Received: from [2a00:1450:4864:20::331] (port=54092 helo=mail-wm1-x331.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ml8J6-0005z9-Bi for qemu-devel@nongnu.org; Thu, 11 Nov 2021 06:31:54 -0500 Received: by mail-wm1-x331.google.com with SMTP id y196so4753381wmc.3 for ; Thu, 11 Nov 2021 03:31:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rjVeR35W+LKbCRb8mOxb8zTeQaratxFe3eeW3XBNWQ8=; b=NV/bCURbrDqk/Gw8TqPAY4Kk2OjBwC6P4+vmj2kr8dbwKMgGr0c6f4QquRJTjDp/JE m2Q9CNmcLq+ApUfW72Uoc+TP65D2/mlYmbqoV3iwapNAegvd33FSxWIb9OZmf/Bk4tj4 Y+cIXmDHPecAvufM2RqNwCF5yz99ju1p/PO0bVvWE3nUI28ytdu0/IlEcyi/Y+9KeYZZ odzk6gnV0IjBIkhO2cNCE2IRgRd/A9ov7QMpyCPsuAfgqde5inzciqNjBd5y224xluuA 8N02wglE9zzkC8iDrCrksiYHzYmLtrxEx5gY/ZZhDQysYAimsV/JOcpTQ0bghygh6kgJ A6OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rjVeR35W+LKbCRb8mOxb8zTeQaratxFe3eeW3XBNWQ8=; b=iCn6ltqVf8eKjfQ3uzuIIIxrLeGvwF5fp/lowo8Tu4tZ9BFzdK5vCPzB49nS2SW8qo N+yc0J69w2jyGdcq/P1Fcs1RAEZSqeKOjnE1+MOVh6jsal9/tksc+Enho9l7GyLKIQSi OSIByE0jwi66OY4V6+c/tTQiguStKHr7mOoD+3PpntvOse3E5J65fRcOuNrtlq1lRz2o UqRP8fRAsCHuWQNmC6MfY4e35dO1vrd9aQI+W3nppCKO+GlF/0ly4+E2GZmx9Y0P7yFF cDNgRLcFg7wnq6BdDF5by8TTpvRkuzbcB45EQgRGrqd4yIWrmznbWX3CUmTogfa6EBqk MONg== X-Gm-Message-State: AOAM533DPr/tztVjiOtlOQC5JggyWFLkCfdyPdyq2dG1/MpkpaEAdIrF m7+wJDbE0yAZ3NCr9KFKfZtAcA== X-Google-Smtp-Source: ABdhPJzGeZ+33T4neZHoTYCHoKARAP/kyy/xe1PKMCDtPARUNom1Xu30VwH1/WLHZPoyYyx4Mr6c0w== X-Received: by 2002:a7b:cd82:: with SMTP id y2mr26074928wmj.10.1636630309898; Thu, 11 Nov 2021 03:31:49 -0800 (PST) Received: from [192.168.8.106] (10.red-95-125-227.dynamicip.rima-tde.net. [95.125.227.10]) by smtp.gmail.com with ESMTPSA id a4sm2473929wmb.39.2021.11.11.03.31.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Nov 2021 03:31:49 -0800 (PST) Subject: Re: [PATCH v3 12/20] target/riscv: Split out the vill from vtype To: LIU Zhiwei , qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <20211111055800.42672-1-zhiwei_liu@c-sky.com> <20211111055800.42672-13-zhiwei_liu@c-sky.com> From: Richard Henderson Message-ID: <61e94a5b-91d5-712e-b185-a3f823c5a30b@linaro.org> Date: Thu, 11 Nov 2021 12:31:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211111055800.42672-13-zhiwei_liu@c-sky.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::331 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -52 X-Spam_score: -5.3 X-Spam_bar: ----- X-Spam_report: (-5.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.999, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: palmer@dabbelt.com, bin.meng@windriver.com, Alistair.Francis@wdc.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/11/21 6:57 AM, LIU Zhiwei wrote: > We need not specially process vtype when XLEN changes. > > Signed-off-by: LIU Zhiwei > --- > target/riscv/cpu.h | 1 + > target/riscv/cpu_helper.c | 3 +-- > target/riscv/csr.c | 13 ++++++++++++- > target/riscv/machine.c | 1 + > target/riscv/vector_helper.c | 3 ++- > 5 files changed, 17 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson > @@ -104,6 +104,7 @@ static const VMStateDescription vmstate_vector = { > VMSTATE_UINTTL(env.vl, RISCVCPU), > VMSTATE_UINTTL(env.vstart, RISCVCPU), > VMSTATE_UINTTL(env.vtype, RISCVCPU), > + VMSTATE_BOOL(env.vill, RISCVCPU), > VMSTATE_END_OF_LIST() Need to bump version. r~