From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMvWm-0002Ve-I3 for qemu-devel@nongnu.org; Mon, 19 Jun 2017 08:11:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMvWh-0000J6-IE for qemu-devel@nongnu.org; Mon, 19 Jun 2017 08:11:32 -0400 References: <1497383329-10393-1-git-send-email-thuth@redhat.com> From: Marcel Apfelbaum Message-ID: <621d32aa-930c-ad9d-3c5e-b3488567bf41@redhat.com> Date: Mon, 19 Jun 2017 15:11:14 +0300 MIME-Version: 1.0 In-Reply-To: <1497383329-10393-1-git-send-email-thuth@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw/pci-bridge/dec: Classify the DEC PCI bridge as bridge device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org, Alexander Graf , "Michael S. Tsirkin" Cc: qemu-ppc@nongnu.org, David Gibson , qemu-trivial@nongnu.org On 13/06/2017 22:48, Thomas Huth wrote: > This way the bridge shows up in the correct section of the > "-device help" text. > > Signed-off-by: Thomas Huth > --- > hw/pci-bridge/dec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/pci-bridge/dec.c b/hw/pci-bridge/dec.c > index cca9362..eb275e1 100644 > --- a/hw/pci-bridge/dec.c > +++ b/hw/pci-bridge/dec.c > @@ -62,6 +62,7 @@ static void dec_21154_pci_bridge_class_init(ObjectClass *klass, void *data) > DeviceClass *dc = DEVICE_CLASS(klass); > PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); > > + set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); > k->realize = dec_pci_bridge_realize; > k->exit = pci_bridge_exitfn; > k->vendor_id = PCI_VENDOR_ID_DEC; > @@ -118,6 +119,7 @@ static void dec_21154_pci_host_class_init(ObjectClass *klass, void *data) > PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); > DeviceClass *dc = DEVICE_CLASS(klass); > > + set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); > k->realize = dec_21154_pci_host_realize; > k->vendor_id = PCI_VENDOR_ID_DEC; > k->device_id = PCI_DEVICE_ID_DEC_21154; > Reviewed-by: Marcel Apfelbaum Thanks, Marcel