From: Richard Henderson <richard.henderson@linaro.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
Laurent Vivier <laurent@vivier.eu>,
Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [PATCH v2] linux-user: Fix strace output for s390x mmap()
Date: Fri, 22 Nov 2024 14:19:03 -0600 [thread overview]
Message-ID: <621ea58f-c5df-4548-83e0-ece0b73eeb71@linaro.org> (raw)
In-Reply-To: <20241120212717.246186-1-iii@linux.ibm.com>
On 11/20/24 15:26, Ilya Leoshkevich wrote:
> print_mmap() assumes that mmap() receives arguments via memory if
> mmap2() is present. s390x (as opposed to s390) does not fit this
> pattern: it does not have mmap2(), but mmap() still receives arguments
> via memory.
>
> Fix by sharing the detection logic between syscall.c and strace.c.
>
> Cc: qemu-stable@nongnu.org
> Fixes: d971040c2d16 ("linux-user: Fix strace output for old_mmap")
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
>
> v1: https://lore.kernel.org/qemu-devel/20241119211138.148806-1-iii@linux.ibm.com/
> v1 -> v2: Share the detection logic between syscall.c and strace.c
> (Richard).
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
and queued.
r~
prev parent reply other threads:[~2024-11-22 20:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 21:26 [PATCH v2] linux-user: Fix strace output for s390x mmap() Ilya Leoshkevich
2024-11-21 9:00 ` Philippe Mathieu-Daudé
2024-11-21 9:26 ` iii
2024-11-21 10:07 ` Philippe Mathieu-Daudé
2024-11-21 10:12 ` iii
2024-11-22 20:19 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=621ea58f-c5df-4548-83e0-ece0b73eeb71@linaro.org \
--to=richard.henderson@linaro.org \
--cc=iii@linux.ibm.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).