[PATCH] Add files: a

[PATCH] Add files: a

[Matheus Tavares Bernardino]

Hi,

tests/functional/test_migration.py says "The test works for both
netcat-traditional and netcat-openbsd packages." But when I run it for
qemu-system-aarch64 on an Ubuntu 22.04 container with netcat-traditional
installed, I get the following error:

TAP version 13
Traceback (most recent call last):
  File "/pwd/tests/functional/test_migration.py", line 97, in test_migration_with_exec
    self.do_migrate(dest_uri, src_uri)
  File "/pwd/tests/functional/test_migration.py", line 72, in do_migrate
    self.assert_migration(source_vm, dest_vm)
  File "/pwd/tests/functional/test_migration.py", line 40, in assert_migration
    self.assertEqual(src_vm.cmd('query-migrate')['status'], 'completed')
AssertionError: 'failed' != 'completed'
- failed
+ completed


not ok 1 test_migration.MigrationTest.test_migration_with_exec
ok 2 test_migration.MigrationTest.test_migration_with_tcp_localhost
ok 3 test_migration.MigrationTest.test_migration_with_unix
1..3

With netcat-openbsd (the default), it runs fine. Perhaps the test is no
longer compatible with netcat-traditional?

QEMU was configured and built with:
../configure --without-default-features --target-list=aarch64-softmmu

Thanks,
Matheus

test_migration.py not working with netcat-traditional

[Matheus Tavares Bernardino]

On Tue, 18 Mar 2025 14:13:03 -0700 Matheus Tavares Bernardino <quic_mathbern@quicinc.com> wrote:
>
> [...]
> 
> Thanks,
> Matheus

Sorry for the original title, I had some placeholder thrash in my buffer and that
ended up going as the subject :facepalm:

test_migration.py not working with netcat-traditional

[Thomas Huth]

On 18/03/2025 22.13, Matheus Tavares Bernardino wrote:
> Hi,
> 
> tests/functional/test_migration.py says "The test works for both
> netcat-traditional and netcat-openbsd packages." But when I run it for
> qemu-system-aarch64 on an Ubuntu 22.04 container with netcat-traditional
> installed, I get the following error:
> 
> TAP version 13
> Traceback (most recent call last):
>    File "/pwd/tests/functional/test_migration.py", line 97, in test_migration_with_exec
>      self.do_migrate(dest_uri, src_uri)
>    File "/pwd/tests/functional/test_migration.py", line 72, in do_migrate
>      self.assert_migration(source_vm, dest_vm)
>    File "/pwd/tests/functional/test_migration.py", line 40, in assert_migration
>      self.assertEqual(src_vm.cmd('query-migrate')['status'], 'completed')
> AssertionError: 'failed' != 'completed'
> - failed
> + completed
> 
> not ok 1 test_migration.MigrationTest.test_migration_with_exec
> ok 2 test_migration.MigrationTest.test_migration_with_tcp_localhost
> ok 3 test_migration.MigrationTest.test_migration_with_unix
> 1..3
> 
> With netcat-openbsd (the default), it runs fine. Perhaps the test is no
> longer compatible with netcat-traditional?
> 
> QEMU was configured and built with:
> ../configure --without-default-features --target-list=aarch64-softmmu

For me it works with both flavors of "nc", the ncat and the netcat one... 
but I'm also running on Fedora. So no clue, could you maybe check whether 
there is some additional information in one of the logfiles in 
tests/functional/aarch64/test_migration.MigrationTest.test_migration_with_exec/ 
?

  Thomas

Re: test_migration.py not working with netcat-traditional

[Daniel P. Berrangé]

On Wed, Mar 19, 2025 at 08:49:53AM +0100, Thomas Huth wrote:
> On 18/03/2025 22.13, Matheus Tavares Bernardino wrote:
> > Hi,
> > 
> > tests/functional/test_migration.py says "The test works for both
> > netcat-traditional and netcat-openbsd packages." But when I run it for
> > qemu-system-aarch64 on an Ubuntu 22.04 container with netcat-traditional
> > installed, I get the following error:
> > 
> > TAP version 13
> > Traceback (most recent call last):
> >    File "/pwd/tests/functional/test_migration.py", line 97, in test_migration_with_exec
> >      self.do_migrate(dest_uri, src_uri)
> >    File "/pwd/tests/functional/test_migration.py", line 72, in do_migrate
> >      self.assert_migration(source_vm, dest_vm)
> >    File "/pwd/tests/functional/test_migration.py", line 40, in assert_migration
> >      self.assertEqual(src_vm.cmd('query-migrate')['status'], 'completed')
> > AssertionError: 'failed' != 'completed'
> > - failed
> > + completed
> > 
> > not ok 1 test_migration.MigrationTest.test_migration_with_exec
> > ok 2 test_migration.MigrationTest.test_migration_with_tcp_localhost
> > ok 3 test_migration.MigrationTest.test_migration_with_unix
> > 1..3
> > 
> > With netcat-openbsd (the default), it runs fine. Perhaps the test is no
> > longer compatible with netcat-traditional?
> > 
> > QEMU was configured and built with:
> > ../configure --without-default-features --target-list=aarch64-softmmu
> 
> For me it works with both flavors of "nc", the ncat and the netcat one...
> but I'm also running on Fedora.

There are three flavour os 'nc' - the traditional netcat, openbsd netcat
and nmap netcat.

IMHO rather than debug differences in these, we'd be better off just
rewriting the test to use socat so we have 1 single impl to think about
instead of 3.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: test_migration.py not working with netcat-traditional

[Thomas Huth]

On 19/03/2025 09.57, Daniel P. Berrangé wrote:
> On Wed, Mar 19, 2025 at 08:49:53AM +0100, Thomas Huth wrote:
>> On 18/03/2025 22.13, Matheus Tavares Bernardino wrote:
>>> Hi,
>>>
>>> tests/functional/test_migration.py says "The test works for both
>>> netcat-traditional and netcat-openbsd packages." But when I run it for
>>> qemu-system-aarch64 on an Ubuntu 22.04 container with netcat-traditional
>>> installed, I get the following error:
>>>
>>> TAP version 13
>>> Traceback (most recent call last):
>>>     File "/pwd/tests/functional/test_migration.py", line 97, in test_migration_with_exec
>>>       self.do_migrate(dest_uri, src_uri)
>>>     File "/pwd/tests/functional/test_migration.py", line 72, in do_migrate
>>>       self.assert_migration(source_vm, dest_vm)
>>>     File "/pwd/tests/functional/test_migration.py", line 40, in assert_migration
>>>       self.assertEqual(src_vm.cmd('query-migrate')['status'], 'completed')
>>> AssertionError: 'failed' != 'completed'
>>> - failed
>>> + completed
>>>
>>> not ok 1 test_migration.MigrationTest.test_migration_with_exec
>>> ok 2 test_migration.MigrationTest.test_migration_with_tcp_localhost
>>> ok 3 test_migration.MigrationTest.test_migration_with_unix
>>> 1..3
>>>
>>> With netcat-openbsd (the default), it runs fine. Perhaps the test is no
>>> longer compatible with netcat-traditional?
>>>
>>> QEMU was configured and built with:
>>> ../configure --without-default-features --target-list=aarch64-softmmu
>>
>> For me it works with both flavors of "nc", the ncat and the netcat one...
>> but I'm also running on Fedora.
> 
> There are three flavour os 'nc' - the traditional netcat, openbsd netcat
> and nmap netcat.

Oh, there is even a third one? ... TIL, I wasn't aware of that yet.

> IMHO rather than debug differences in these, we'd be better off just
> rewriting the test to use socat so we have 1 single impl to think about
> instead of 3.

That's a good idea. Alternatively we could also limit the test to "ncat", 
AFAICT that name is not used by the other twos, is it?

  Thomas