From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71C9BC433E7 for ; Thu, 8 Oct 2020 16:33:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A71D921D7D for ; Thu, 8 Oct 2020 16:33:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TObF7ARt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A71D921D7D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQYrB-0001Z0-J0 for qemu-devel@archiver.kernel.org; Thu, 08 Oct 2020 12:33:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQYpN-0000RV-3h for qemu-devel@nongnu.org; Thu, 08 Oct 2020 12:31:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36740) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kQYpI-0000QF-GP for qemu-devel@nongnu.org; Thu, 08 Oct 2020 12:31:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602174690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2Ci99ngCZf8aM/vl7wnL2jLf2OFmVCtAeGhxZ2lmby0=; b=TObF7ARt/YFSeWwX+Su2cvs/ykoJARtctpOf+Eazcb5Wxumi9u4t9Fk3EIl2Ozr6T6M2AX S7vEfgyQmIBCnGd40Rv4+T9xOQrrd+lXUUko4serEAYqjc99kbbOAxpMLLtdLF1aUIxoUu +ENtqKCRjz2aWZJ2F2N2cY/a8Qfp2x4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-RVOi4M5cNyGBdFZNVwG56g-1; Thu, 08 Oct 2020 12:31:28 -0400 X-MC-Unique: RVOi4M5cNyGBdFZNVwG56g-1 Received: by mail-wm1-f69.google.com with SMTP id u5so3337601wme.3 for ; Thu, 08 Oct 2020 09:31:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2Ci99ngCZf8aM/vl7wnL2jLf2OFmVCtAeGhxZ2lmby0=; b=RDxr+hVVcFSqvQijkzlpzZtLdx009J9D0rBBwiHlNONeMtIzhlnuVewkQgCYOd5VZU oiP4o6GRFTHlz/vnN/X4j/fkyqe6ZgrLdi79junzvcB8z5HizDbrPn9gjKIQJUcJLjJJ iWOjETO8jufj3jVNLqg0U5saU4g+d/5z6EXI3HHtqy277c5m7xCANPpD1LEqci2dO945 GeBZicFhziXrrCaDmPF5l8+GaHzrl/Rn9bkBepCBUDbp4GZvJ82IE2JBcvbWE+WSOvnZ lDHGTHsmpM2ZWhRr9Uaz/CRhk4nP55e2Rl/2nDcA53HFS1ixAPsfdO640i8ELWuadNx9 mTcg== X-Gm-Message-State: AOAM532xwusUBuN+3LKkaCA3ReScvDXztxAKWi9jPzRd9m1I2OYfPd2V ZkUDuKl4GTrR7j7DiPAUVu+ABXoOgaIiQ3cFCPFf2I2ehP/7pkQ2r2Fi77nVqz1dq/d38SdMeHk +Oauo0d6sfZUgIeU= X-Received: by 2002:adf:f986:: with SMTP id f6mr4838338wrr.38.1602174687104; Thu, 08 Oct 2020 09:31:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/iD6zHM3has6VpcF+DtIYoVlDbh06cFkn94FGwyS8Sh5vgm9WO5O4Okyt4OKBRMAQ1tqFIA== X-Received: by 2002:adf:f986:: with SMTP id f6mr4838302wrr.38.1602174686770; Thu, 08 Oct 2020 09:31:26 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:bb8c:429c:6de1:f4ec? ([2001:b07:6468:f312:bb8c:429c:6de1:f4ec]) by smtp.gmail.com with ESMTPSA id 142sm8816465wma.14.2020.10.08.09.31.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Oct 2020 09:31:26 -0700 (PDT) Subject: Re: does make check now require TCG? Or is it a parallelism issue? To: Claudio Fontana References: <11ef73ff-4178-b3e8-2e49-44ff014a13ed@suse.de> <569520f6-adf6-6212-9625-a184bf499e24@redhat.com> <16b01645-7a80-7f79-aba0-fd6c6c8ba6e8@suse.de> From: Paolo Bonzini Message-ID: <62339951-606d-15d0-e2ad-bd46f3e6de87@redhat.com> Date: Thu, 8 Oct 2020 18:31:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <16b01645-7a80-7f79-aba0-fd6c6c8ba6e8@suse.de> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/08 02:56:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.214, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Bennee , qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 08/10/20 18:25, Claudio Fontana wrote: > On 10/8/20 5:34 PM, Claudio Fontana wrote: >> On 10/8/20 5:02 PM, Paolo Bonzini wrote: >>> On 08/10/20 16:48, Claudio Fontana wrote: >>>> on master, a build without tcg like: >>>> >>>> exec '../configure' '--disable-tcg' '--enable-kvm' '--enable-hax' "$@" >>>> >>>> make -j120 check >>>> Generating qemu-version.h with a meson_exe.py custom command >>>> make: *** No rule to make target 'qemu-system-aarch64', needed by 'check-block'. Stop. >>>> make: *** Waiting for unfinished jobs.... >>>> >>>> qemu-system-aarch64 is required for check-block now? >>> >>> No, it's not, it's an unnecessary dependency. This will fix it: >>> >>> diff --git a/tests/Makefile.include b/tests/Makefile.include >>> index 5aca98e60c..1ca70d88ce 100644 >>> --- a/tests/Makefile.include >>> +++ b/tests/Makefile.include >>> @@ -140,7 +140,7 @@ QEMU_IOTESTS_HELPERS-$(CONFIG_LINUX) = tests/qemu-iotests/socket_scm_helper$(EXE >>> check: check-block >>> check-block: $(SRC_PATH)/tests/check-block.sh qemu-img$(EXESUF) \ >>> qemu-io$(EXESUF) qemu-nbd$(EXESUF) $(QEMU_IOTESTS_HELPERS-y) \ >>> - $(patsubst %-softmmu,qemu-system-%,$(filter %-softmmu,$(TARGET_DIRS))) >>> + qemu-system-$(patsubst ppc64%,ppc64, $(shell uname -m)) >>> @$< >>> endif >>> >>> >>> >> >> thanks this works! >> >>>> If I run without -j: >>>> >>>> Running test qtest-i386: qmp-cmd-test >>>> Broken pipe >>>> ../tests/qtest/libqtest.c:175: kill_qemu() detected QEMU death from signal 6 (Aborted) (core dumped) >>>> ERROR qtest-i386: qmp-cmd-test - too few tests run (expected 53, got 45) >>>> make: *** [Makefile.mtest:1074: run-test-151] Error 1 >>> >>> This one is different and I've never seen it. >> >> This one seems an additional, non-tcg build only error, will update when I have more details. >> >>> >>> Paolo >>> >> >> Ciao, >> >> Claudio >> > > Seems to be some QMP calls to icount code from replay happening during the tests, which of course do not find any icount there.. > > (gdb) bt > #0 0x00007f2b4d115520 in raise () at /lib64/libc.so.6 > #1 0x00007f2b4d116b01 in abort () at /lib64/libc.so.6 > #2 0x000056295aaf5889 in icount_get_raw () at ../stubs/icount.c:20 > #3 0x000056295a7934a5 in replay_get_current_icount () at ../replay/replay.c:71 > #4 0x000056295a78719d in qmp_query_replay (errp=errp@entry=0x7ffe727a4538) at ../replay/replay-debugging.c:55 > #5 0x000056295aac0137 in qmp_marshal_query_replay (args=, ret=0x7ffe727a45a0, errp=0x7ffe727a4598) > at qapi/qapi-commands-replay.c:55 > #6 0x000056295aae88a3 in qmp_dispatch > (cmds=0x56295b3b5ce0 , request=request@entry=0x7f2b3c004db0, allow_oob=) at ../qapi/qmp-dispatch.c:155 > #7 0x000056295aa6ab7f in monitor_qmp_dispatch (mon=0x56295bee7f80, req=0x7f2b3c004db0) at ../monitor/qmp.c:145 > #8 0x000056295aa6b3ba in monitor_qmp_bh_dispatcher (data=) at ../monitor/qmp.c:234 > #9 0x000056295aaeb5b8 in aio_bh_poll (ctx=ctx@entry=0x56295bcd5130) at ../util/async.c:164 > #10 0x000056295aad76de in aio_dispatch (ctx=0x56295bcd5130) at ../util/aio-posix.c:380 > #11 0x000056295aaeb49e in aio_ctx_dispatch (source=, callback=, user_data=) > at ../util/async.c:306 > #12 0x00007f2b4e268f07 in g_main_context_dispatch () at /usr/lib64/libglib-2.0.so.0 > #13 0x000056295aac96fa in glib_pollfds_poll () at ../util/main-loop.c:221 > #14 0x000056295aac96fa in os_host_main_loop_wait (timeout=-1) at ../util/main-loop.c:244 > #15 0x000056295aac96fa in main_loop_wait (nonblocking=nonblocking@entry=0) at ../util/main-loop.c:520 > #16 0x000056295a99083d in qemu_main_loop () at ../softmmu/vl.c:1677 > #17 0x000056295a71b17e in main (argc=, argv=, envp=) at ../softmmu/main.c:50 > Ah, query-replay probably should return an error if !tcg_enabled(). Paolo