From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CCEEC54750 for ; Wed, 28 Aug 2024 08:33:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sjE6O-0002dN-Tw; Wed, 28 Aug 2024 04:32:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sjE6N-0002cO-8R for qemu-devel@nongnu.org; Wed, 28 Aug 2024 04:32:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sjE6K-0001IS-Jh for qemu-devel@nongnu.org; Wed, 28 Aug 2024 04:32:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724833943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rBL1+REy76nB2DG/I+YGdluhihWInWCbsi9Tvlx6Sco=; b=Yl0qgOkLGjW/OPQ2WVCZvsAiYxmCvI2WgIkfmUeqZ3hs7aMFJUpPcnGx+INObECLcdHQ4b 636QlteAukE1D077/dGbIYFc5LT8KatnqFEAma9yNCBonI040EpTQt+hrAK/mzDdI8QSW8 18li49ZFNBWqJGga8mnScpD3U3mtB9U= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-32-oQepYAuQP4Kx9OmaJNFUyQ-1; Wed, 28 Aug 2024 04:32:20 -0400 X-MC-Unique: oQepYAuQP4Kx9OmaJNFUyQ-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-371914b5caaso3987442f8f.0 for ; Wed, 28 Aug 2024 01:32:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724833939; x=1725438739; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rBL1+REy76nB2DG/I+YGdluhihWInWCbsi9Tvlx6Sco=; b=tcIsjoJibe/7vyCL1QnrDRCkIA1kKR2B0gxTZNgU090oB3u0Qbm3ELavEbBkUS5msH +0xJnVMVlGt+JKO3sRa8twhCs+FUJs7yZFVhEmsyEkhpsevP+XE/JUoKM8CaqhAhGzc6 AK0R9zXxpxYRtylIz6vWwyIDOgEI2xUE3IspZolrz5mHWTXHZYaWSGLXQyKRXnJwxQ84 qBALMMJ1rWuB9HBQh+5gQrEyopQ07RwJ8e15ywN9cipH6ekFVKXhJ9oqcXEwG5C9UnNF pPnAGBdnWMGvgHWRSZXzKepIxgXgKpMbCxbrLbYQXR3IxBOS5Z9Ut3Uket+Oe3nQDQVz XIug== X-Gm-Message-State: AOJu0YzCr4i2cbwak8I20xpcjpcagKX23SLeiCA1IZpXYH89XNhvcj3+ LAa3ALFHNFkIfmVwm0d9rYbboguTIvygGi1zRnNBwUAelrUdwGx3Ep1IZSTsZ8fRnieYePphq/p S++s5qrX2XwPd3rwE2RkBGdoyTg1MDOZ8s65YpZkO/h9FVlCXymaR X-Received: by 2002:a5d:6948:0:b0:362:7c2e:e9f7 with SMTP id ffacd0b85a97d-3749681f994mr750742f8f.32.1724833938732; Wed, 28 Aug 2024 01:32:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6KgD11KWJRg2w+K5vfYoeWGCl4Q0Yca4Fezt8tpnr9zibznPQ2LiEBerOjzu5zpNYri+EZQ== X-Received: by 2002:a5d:6948:0:b0:362:7c2e:e9f7 with SMTP id ffacd0b85a97d-3749681f994mr750706f8f.32.1724833938188; Wed, 28 Aug 2024 01:32:18 -0700 (PDT) Received: from [192.168.0.6] (ip-109-43-179-35.web.vodafone.de. [109.43.179.35]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ba63abea3sm13715165e9.28.2024.08.28.01.32.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Aug 2024 01:32:17 -0700 (PDT) Message-ID: <623915fb-4d6d-4de8-921a-cf6ad315c060@redhat.com> Date: Wed, 28 Aug 2024 10:32:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PULL 10/11] crypto: push error reporting into TLS session I/O APIs To: Markus Armbruster , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= Cc: qemu-devel@nongnu.org, Paolo Bonzini , Laurent Vivier , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Eric Blake , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , Hyman Huang , Qemu-block , Kevin Wolf , Hanna Reitz References: <20240724094706.30396-1-berrange@redhat.com> <20240724094706.30396-11-berrange@redhat.com> <25ea7357-99e1-4fdf-9ef8-885cb7e75f47@redhat.com> <87plpumonz.fsf@pond.sub.org> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <87plpumonz.fsf@pond.sub.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 27/08/2024 09.05, Markus Armbruster wrote: > Daniel P. Berrangé writes: > >> On Mon, Aug 12, 2024 at 05:38:41PM +0200, Thomas Huth wrote: >>> On 24/07/2024 11.47, Daniel P. Berrangé wrote: >>>> The current TLS session I/O APIs just return a synthetic errno >>>> value on error, which has been translated from a gnutls error >>>> value. This looses a large amount of valuable information that >>>> distinguishes different scenarios. >>>> >>>> Pushing population of the "Error *errp" object into the TLS >>>> session I/O APIs gives more detailed error information. >>>> >>>> Reviewed-by: Philippe Mathieu-Daudé >>>> Signed-off-by: Daniel P. Berrangé >>>> --- >>> >>> Hi Daniel! >>> >>> iotest 233 is failing for me with -raw now, and bisection >>> points to this commit. Output is: >>> >>> --- .../qemu/tests/qemu-iotests/233.out >>> +++ /tmp/qemu/tests/qemu-iotests/scratch/raw-file-233/233.out.bad >>> @@ -69,8 +69,8 @@ >>> 1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) >>> >>> == check TLS with authorization == >>> -qemu-img: Could not open 'driver=nbd,host=127.0.0.1,port=PORT,tls-creds=tls0': Failed to read option reply: Cannot read from TLS channel: Software caused connection abort >>> -qemu-img: Could not open 'driver=nbd,host=127.0.0.1,port=PORT,tls-creds=tls0': Failed to read option reply: Cannot read from TLS channel: Software caused connection abort >>> +qemu-img: Could not open 'driver=nbd,host=127.0.0.1,port=PORT,tls-creds=tls0': Failed to read option reply: Cannot read from TLS channel: The TLS connection was non-properly terminated. >>> +qemu-img: Could not open 'driver=nbd,host=127.0.0.1,port=PORT,tls-creds=tls0': Failed to read option reply: Cannot read from TLS channel: The TLS connection was non-properly terminated. >> >> This is an expected change. Previously squashed the real GNUTLS error >> into ECONNABORTED: >> >> - case GNUTLS_E_PREMATURE_TERMINATION: >> - errno = ECONNABORTED; >> - break; >> >> >> now we report the original gnutls root cause. >> >> IOW, we need to update the expected output files. > > Has this been done? No, I think the problem still persists. Thomas