From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 02/32] tests/docker: all add DOCKER_BUILDKIT to RUNC environment
Date: Thu, 16 Mar 2023 09:37:09 -0700 [thread overview]
Message-ID: <623e7cd7-1bf6-b12c-0943-02ecfee318e0@linaro.org> (raw)
In-Reply-To: <20230315174331.2959-3-alex.bennee@linaro.org>
On 3/15/23 10:43, Alex Bennée wrote:
> It seems we also need to pass DOCKER_BUILDKIT as an argument to docker
> itself to get the full benefit of caching.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Suggested-by: Fabiano Rosas <farosas@suse.de>
> ---
> tests/docker/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Tested-by: Richard Henderson <richard.henderson@linaro.org>
r~
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 54ed77f671..9401525325 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -39,7 +39,7 @@ docker-qemu-src: $(DOCKER_SRC_COPY)
> # General rule for building docker images.
> docker-image-%: $(DOCKER_FILES_DIR)/%.docker
> $(call quiet-command, \
> - $(RUNC) build \
> + DOCKER_BUILDKIT=1 $(RUNC) build \
> $(if $V,,--quiet) \
> $(if $(NOCACHE),--no-cache, \
> $(if $(DOCKER_REGISTRY),--cache-from $(DOCKER_REGISTRY)/qemu/$*)) \
next prev parent reply other threads:[~2023-03-16 16:37 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 17:42 [PATCH v2 00/32] tweaks and fixes for 8.0-rc1 (tests, plugins, docs) Alex Bennée
2023-03-15 17:43 ` [PATCH v2 01/32] tests/avocado: update AArch64 tests to Alpine 3.17.2 Alex Bennée
2023-03-15 17:43 ` [PATCH v2 02/32] tests/docker: all add DOCKER_BUILDKIT to RUNC environment Alex Bennée
2023-03-16 16:37 ` Richard Henderson [this message]
2023-03-17 12:05 ` Thomas Huth
2023-03-15 17:43 ` [PATCH v2 03/32] scripts/ci: add libslirp-devel to build-environment Alex Bennée
2023-03-15 17:43 ` [PATCH v2 04/32] scripts/ci: update gitlab-runner playbook to handle CentOS Alex Bennée
2023-03-15 17:43 ` [PATCH v2 05/32] gitlab: update centos-8-stream job Alex Bennée
2023-03-17 7:24 ` Thomas Huth
2023-03-15 17:43 ` [PATCH v2 06/32] include/qemu: add documentation for memory callbacks Alex Bennée
2023-03-16 16:08 ` Richard Henderson
2023-03-17 12:11 ` Thomas Huth
2023-03-15 17:43 ` [PATCH v2 07/32] tests/tcg: add some help output for running individual tests Alex Bennée
2023-03-16 16:15 ` Richard Henderson
2023-03-17 12:08 ` Thomas Huth
2023-03-15 17:43 ` [PATCH v2 08/32] tests/tcg: disable pauth for aarch64 gdb tests Alex Bennée
2023-03-15 17:43 ` [PATCH v2 09/32] include/exec: fix kerneldoc definition Alex Bennée
2023-03-16 16:15 ` Richard Henderson
2023-03-16 16:50 ` Peter Maydell
2023-03-15 17:43 ` [PATCH v2 10/32] tests/avocado: don't use tags to define drive Alex Bennée
2023-03-15 17:43 ` [PATCH v2 11/32] tcg: Clear plugin_mem_cbs on TB exit Alex Bennée
2023-03-15 17:43 ` [PATCH v2 12/32] tcg: Drop plugin_gen_disable_mem_helpers from tcg_gen_exit_tb Alex Bennée
2023-03-15 17:43 ` [PATCH v2 13/32] include/qemu/plugin: Remove QEMU_PLUGIN_ASSERT Alex Bennée
2023-03-15 17:43 ` [PATCH v2 14/32] *: Add missing includes of qemu/error-report.h Alex Bennée
2023-03-15 17:43 ` [PATCH v2 15/32] *: Add missing includes of qemu/plugin.h Alex Bennée
2023-03-15 17:43 ` [PATCH v2 16/32] include/qemu: Split out plugin-event.h Alex Bennée
2023-03-15 17:43 ` [PATCH v2 17/32] include/qemu/plugin: Inline qemu_plugin_disable_mem_helpers Alex Bennée
2023-03-15 17:43 ` [PATCH v2 18/32] iotests: explicitly pass source/build dir to 'check' command Alex Bennée
2023-03-15 17:43 ` [PATCH v2 19/32] iotests: allow test discovery before building Alex Bennée
2023-03-15 17:43 ` [PATCH v2 20/32] iotests: strip subdir path when listing tests Alex Bennée
2023-03-15 17:43 ` [PATCH v2 21/32] iotests: print TAP protocol version when reporting tests Alex Bennée
2023-03-15 17:43 ` [PATCH v2 22/32] iotests: connect stdin to /dev/null when running tests Alex Bennée
2023-03-15 17:43 ` [PATCH v2 23/32] iotests: always use a unique sub-directory per test Alex Bennée
2023-03-15 17:43 ` [PATCH v2 24/32] iotests: register each I/O test separately with meson Alex Bennée
2023-03-15 17:43 ` [PATCH v2 25/32] iotests: remove the check-block.sh script Alex Bennée
2023-03-15 17:43 ` [PATCH v2 26/32] contrib/gitdm: Add ASPEED Technology to the domain map Alex Bennée
2023-03-15 17:43 ` [PATCH v2 27/32] contrib/gitdm: Add SYRMIA " Alex Bennée
2023-03-15 17:43 ` [PATCH v2 28/32] contrib/gitdm: add Amazon " Alex Bennée
2023-03-15 19:18 ` Durrant, Paul
2023-03-17 10:34 ` Alexander Graf
2023-03-15 17:43 ` [PATCH v2 29/32] contrib/gitdm: add Alibaba to the domain-map Alex Bennée
2023-03-15 17:43 ` [PATCH v2 30/32] contrib/gitdm: add revng to domain map Alex Bennée
2023-03-15 22:01 ` Alessandro Di Federico via
2023-03-15 17:43 ` [PATCH v2 31/32] contrib/gitdm: add more individual contributors Alex Bennée
2023-03-17 7:26 ` Thomas Huth
2023-03-15 17:43 ` [PATCH v2 32/32] contrib/gitdm: add group map for AMD Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=623e7cd7-1bf6-b12c-0943-02ecfee318e0@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).