From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwAKh-0003pj-0f for qemu-devel@nongnu.org; Mon, 17 Oct 2016 12:00:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwAKZ-00075L-Dl for qemu-devel@nongnu.org; Mon, 17 Oct 2016 12:00:11 -0400 References: <1476522280-23211-1-git-send-email-ashijeetacharya@gmail.com> <1476522280-23211-3-git-send-email-ashijeetacharya@gmail.com> <20161017125724.GG4821@noname.redhat.com> From: Eric Blake Message-ID: <6246d235-edd5-130f-df71-522b4a3a7ad2@redhat.com> Date: Mon, 17 Oct 2016 10:59:50 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2wMl8WXNdoXlvA5R9O196mBjK5HEMqL4L" Subject: Re: [Qemu-devel] [v2 2/5] block/ssh: Add InetSocketAddress and accept it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashijeet Acharya , Kevin Wolf Cc: Max Reitz , "Richard W.M. Jones" , jcody@redhat.com, Markus Armbruster , "Daniel P. Berrange" , Gerd Hoffmann , Paolo Bonzini , QEMU Developers , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2wMl8WXNdoXlvA5R9O196mBjK5HEMqL4L From: Eric Blake To: Ashijeet Acharya , Kevin Wolf Cc: Max Reitz , "Richard W.M. Jones" , jcody@redhat.com, Markus Armbruster , "Daniel P. Berrange" , Gerd Hoffmann , Paolo Bonzini , QEMU Developers , qemu-block@nongnu.org Message-ID: <6246d235-edd5-130f-df71-522b4a3a7ad2@redhat.com> Subject: Re: [v2 2/5] block/ssh: Add InetSocketAddress and accept it References: <1476522280-23211-1-git-send-email-ashijeetacharya@gmail.com> <1476522280-23211-3-git-send-email-ashijeetacharya@gmail.com> <20161017125724.GG4821@noname.redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/17/2016 10:44 AM, Ashijeet Acharya wrote: >=20 > I think, its better to keep using atoi() and check if it returns a '0' Please not atoi(), as it lacks sane error checking. It cannot tell the difference between '1' and '1garbage'. It's obvious that you want to treat both '0' and 'name' as an error, but that is not the only error you want to flag, thus atoi() is insufficient to flag all the errors you want. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2wMl8WXNdoXlvA5R9O196mBjK5HEMqL4L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYBPV2AAoJEKeha0olJ0NqTpUH/223D14Pu0K8FLCCLuI9vTt3 kHcADCK39Tj56UWaWhUuHdrePkGUNbzlZmU/pqXbBLMXVDQB8e45yvOe2B6yGCLU IHiuLdVAlwTAXnJfmUfVgux5ApD2bOS7T0dtI0/HuXZJu/tXyMZFry7GTcBb0Dwa y43XxruNNGFIa5AH3pED7l1nScwne+jLnARJxUHd+zwYEUzzfzw645fUplDUK57k re8Qmj/7UZHNItBY42BGWGQ6Gq5tmSCP51qvkU1bghgDLnxPr7fMtUUwvfqe8Rnm x5A1rL5w73rP53uJ5WrVdLN9RX6Wyof15O3UUPtd7+WRmH4Jcsfqw8JDh5wmbms= =Tobz -----END PGP SIGNATURE----- --2wMl8WXNdoXlvA5R9O196mBjK5HEMqL4L--