From: David Woodhouse <dwmw2@infradead.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Nabih Estefan <nabihestefan@google.com>, Hao Wu <wuhaotsh@google.com>
Subject: Re: [PATCH 1/2] hw/arm/npcm7xx: Call qemu_configure_nic_device() for GMAC modules
Date: Tue, 06 Feb 2024 09:36:11 -0800 [thread overview]
Message-ID: <624db586bcc44a78917b1cb801e6481ce47f426d.camel@infradead.org> (raw)
In-Reply-To: <20240206171231.396392-2-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
On Tue, 2024-02-06 at 17:12 +0000, Peter Maydell wrote:
> The patchset adding the GMAC ethernet to this SoC crossed in the
> mail with the patchset cleaning up the NIC handling. When we
> create the GMAC modules we must call qemu_configure_nic_device()
> so that the user has the opportunity to use the -nic commandline
> option to create a network backend and connect it to the GMACs.
>
> Add the missing call.
>
> Fixes: 21e5326a7c ("hw/arm: Add GMAC devices to NPCM7XX SoC")
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]
next prev parent reply other threads:[~2024-02-06 17:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 17:12 [PATCH 0/2] Fix issues with npcm7xx and recent NIC cleanup Peter Maydell
2024-02-06 17:12 ` [PATCH 1/2] hw/arm/npcm7xx: Call qemu_configure_nic_device() for GMAC modules Peter Maydell
2024-02-06 17:36 ` David Woodhouse [this message]
2024-02-06 17:12 ` [PATCH 2/2] tests/qtest/npcm7xx_emc-test: Connect all NICs to a backend Peter Maydell
2024-02-06 17:34 ` Peter Maydell
2024-02-06 17:36 ` David Woodhouse
2024-02-06 17:46 ` Peter Maydell
2024-02-07 7:33 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=624db586bcc44a78917b1cb801e6481ce47f426d.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=nabihestefan@google.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).