From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Janosch Frank" <frankja@linux.ibm.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v5 5/5] dump: Add create_win_dump() stub for non-x86 targets
Date: Fri, 24 Feb 2023 11:10:17 -1000 [thread overview]
Message-ID: <6254606d-7164-50c3-a0c1-e3614810978d@linaro.org> (raw)
In-Reply-To: <20230224073850.84913-6-philmd@linaro.org>
On 2/23/23 21:38, Philippe Mathieu-Daudé wrote:
> -specific_ss.add(when: 'CONFIG_SOFTMMU', if_true: [files('dump.c'), snappy, lzo])
> +softmmu_ss.add(when: 'CONFIG_SOFTMMU', if_true: [files('dump.c'), snappy, lzo])
You can remove the when: as well, yes?
r~
next prev parent reply other threads:[~2023-02-24 21:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 7:38 [PATCH v5 0/5] dump: Make most of it target agnostic (build once) Philippe Mathieu-Daudé
2023-02-24 7:38 ` [PATCH v5 1/5] dump: Replace tswapN() -> cpu_to_dumpN() Philippe Mathieu-Daudé
2023-02-24 7:38 ` [PATCH v5 2/5] dump: Replace TARGET_PAGE_SIZE -> qemu_target_page_size() Philippe Mathieu-Daudé
2023-02-24 7:38 ` [PATCH v5 3/5] dump: Clean included headers Philippe Mathieu-Daudé
2023-02-24 7:38 ` [PATCH v5 4/5] dump: Introduce win_dump_available() Philippe Mathieu-Daudé
2023-02-24 7:51 ` Thomas Huth
2023-02-24 7:38 ` [PATCH v5 5/5] dump: Add create_win_dump() stub for non-x86 targets Philippe Mathieu-Daudé
2023-02-24 7:52 ` Thomas Huth
2023-02-24 21:10 ` Richard Henderson [this message]
2023-02-25 9:45 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6254606d-7164-50c3-a0c1-e3614810978d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=frankja@linux.ibm.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).