From: David Hildenbrand <david@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH v1] cpus: make pause_all_cpus() play with SMP on single threaded TCG
Date: Mon, 11 Dec 2017 17:40:09 +0100 [thread overview]
Message-ID: <626bacaa-c24a-1cc0-14a7-d9ea4592b2f5@redhat.com> (raw)
In-Reply-To: <3f0c7605-4090-c1f6-c40d-06aab9a3e992@redhat.com>
> int vm_stop(RunState state)
> {
> if (qemu_in_vcpu_thread()) {
> @@ -1818,7 +1809,8 @@ int vm_stop(RunState state)
> * FIXME: should not return to device code in case
> * vm_stop() has been requested.
> */
> - cpu_stop_current();
> + qemu_cpu_stop(current_cpu);
> + cpu_exit(current_cpu);
We're doing the cpu_exit() now after the broadcast, is this ok?
Also we drop the check for current_cpu, I assume this is also ok.
> return 0;
> }
>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2017-12-11 16:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 19:12 [Qemu-devel] [PATCH v1] cpus: make pause_all_cpus() play with SMP on single threaded TCG David Hildenbrand
2017-12-11 16:24 ` Paolo Bonzini
2017-12-11 16:40 ` David Hildenbrand [this message]
2017-12-11 16:44 ` David Hildenbrand
2017-12-11 16:48 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=626bacaa-c24a-1cc0-14a7-d9ea4592b2f5@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).