From: David Hildenbrand <david@redhat.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
Richard Henderson <richard.henderson@linaro.org>,
Thomas Huth <thuth@redhat.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [PATCH v2 07/14] target/s390x: Fix assertion failure in VFMIN/VFMAX with type 13
Date: Wed, 19 Jul 2023 11:47:32 +0200 [thread overview]
Message-ID: <62807a3b-f341-52dc-fa79-e8f72754752c@redhat.com> (raw)
In-Reply-To: <20230719094620.363206-8-iii@linux.ibm.com>
On 19.07.23 11:44, Ilya Leoshkevich wrote:
> Type 13 is reserved, so using it should result in specification
> exception. Due to an off-by-1 error the code triggers an assertion at a
> later point in time instead.
>
> Cc: qemu-stable@nongnu.org
> Fixes: da4807527f3b ("s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
> target/s390x/tcg/translate_vx.c.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/tcg/translate_vx.c.inc b/target/s390x/tcg/translate_vx.c.inc
> index 43dfbfd03f6..f8df121d3d3 100644
> --- a/target/s390x/tcg/translate_vx.c.inc
> +++ b/target/s390x/tcg/translate_vx.c.inc
> @@ -3047,7 +3047,7 @@ static DisasJumpType op_vfmax(DisasContext *s, DisasOps *o)
> const uint8_t m5 = get_field(s, m5);
> gen_helper_gvec_3_ptr *fn;
>
> - if (m6 == 5 || m6 == 6 || m6 == 7 || m6 > 13) {
> + if (m6 == 5 || m6 == 6 || m6 == 7 || m6 >= 13) {
> gen_program_exception(s, PGM_SPECIFICATION);
> return DISAS_NORETURN;
> }
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-07-19 9:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 9:44 [PATCH v2 00/14] target/s390x: Miscellaneous TCG fixes, part 2 Ilya Leoshkevich
2023-07-19 9:44 ` [PATCH v2 01/14] target/s390x: Make CKSM raise an exception if R2 is odd Ilya Leoshkevich
2023-07-19 9:44 ` [PATCH v2 02/14] target/s390x: Fix CLM with M3=0 Ilya Leoshkevich
2023-07-19 9:44 ` [PATCH v2 03/14] target/s390x: Fix CONVERT TO LOGICAL/FIXED with out-of-range inputs Ilya Leoshkevich
2023-07-19 9:44 ` [PATCH v2 04/14] target/s390x: Fix ICM with M3=0 Ilya Leoshkevich
2023-07-19 9:44 ` [PATCH v2 05/14] target/s390x: Make MC raise specification exception when class >= 16 Ilya Leoshkevich
2023-07-19 9:44 ` [PATCH v2 06/14] tcg/{i386, s390x}: Add earlyclobber to the op_add2's first output Ilya Leoshkevich
2023-07-19 12:08 ` Philippe Mathieu-Daudé
2023-07-19 12:30 ` Ilya Leoshkevich
2023-07-19 12:42 ` Philippe Mathieu-Daudé
2023-07-19 14:04 ` Philippe Mathieu-Daudé
2023-07-19 9:44 ` [PATCH v2 07/14] target/s390x: Fix assertion failure in VFMIN/VFMAX with type 13 Ilya Leoshkevich
2023-07-19 9:47 ` David Hildenbrand [this message]
2023-07-19 9:44 ` [PATCH v2 08/14] tests/tcg/s390x: Test CKSM Ilya Leoshkevich
2023-07-19 14:20 ` Thomas Huth
2023-07-19 14:23 ` Ilya Leoshkevich
2023-07-19 9:44 ` [PATCH v2 09/14] tests/tcg/s390x: Test CLGEBR and CGEBRA Ilya Leoshkevich
2023-07-19 14:34 ` Thomas Huth
2023-07-19 9:44 ` [PATCH v2 10/14] tests/tcg/s390x: Test CLM Ilya Leoshkevich
2023-07-19 14:36 ` Thomas Huth
2023-07-19 9:44 ` [PATCH v2 11/14] tests/tcg/s390x: Test ICM Ilya Leoshkevich
2023-07-19 14:37 ` Thomas Huth
2023-07-19 9:44 ` [PATCH v2 12/14] tests/tcg/s390x: Test MC Ilya Leoshkevich
2023-07-19 14:39 ` Thomas Huth
2023-07-19 9:44 ` [PATCH v2 13/14] tests/tcg/s390x: Test STPQ Ilya Leoshkevich
2023-07-19 14:39 ` Thomas Huth
2023-07-19 9:44 ` [PATCH v2 14/14] tests/tcg/s390x: Test VCKSM Ilya Leoshkevich
2023-07-19 14:40 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62807a3b-f341-52dc-fa79-e8f72754752c@redhat.com \
--to=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).