From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btdc7-0003sg-0G for qemu-devel@nongnu.org; Mon, 10 Oct 2016 12:39:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btdc5-0007jm-5I for qemu-devel@nongnu.org; Mon, 10 Oct 2016 12:39:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btdc4-0007jb-Ui for qemu-devel@nongnu.org; Mon, 10 Oct 2016 12:39:41 -0400 References: <133a4c1d-d029-0bc2-d538-4e5c8e3dac1b@redhat.com> <20161010154625.14881-1-alex.bennee@linaro.org> From: Paolo Bonzini Message-ID: <6286d817-fbe6-afdb-2352-e5cf0b54d859@redhat.com> Date: Mon, 10 Oct 2016 18:39:36 +0200 MIME-Version: 1.0 In-Reply-To: <20161010154625.14881-1-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] kvm-all: don't use stale dbg_data->cpu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , borntraeger@de.ibm.com, imbrenda@linux.vnet.ibm.com Cc: qemu-devel@nongnu.org, "open list:Overall" On 10/10/2016 17:46, Alex Benn=C3=A9e wrote: > The changes to run_on_cpu and friends mean that all helpers are passed > the CPUState of vCPU they are running on. The conversion missed the > field in commit e0eeb4a21a3ca4b296220ce4449d8acef9de9049 which > introduced bugs. >=20 > Reported-by: Claudio Imbrenda > Signed-off-by: Alex Benn=C3=A9e > --- > kvm-all.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/kvm-all.c b/kvm-all.c > index efb5fe3..3dcce16 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -2215,15 +2215,14 @@ int kvm_sw_breakpoints_active(CPUState *cpu) > =20 > struct kvm_set_guest_debug_data { > struct kvm_guest_debug dbg; > - CPUState *cpu; > int err; > }; > =20 > -static void kvm_invoke_set_guest_debug(CPUState *unused_cpu, void *dat= a) > +static void kvm_invoke_set_guest_debug(CPUState *cpu, void *data) > { > struct kvm_set_guest_debug_data *dbg_data =3D data; > =20 > - dbg_data->err =3D kvm_vcpu_ioctl(dbg_data->cpu, KVM_SET_GUEST_DEBU= G, > + dbg_data->err =3D kvm_vcpu_ioctl(cpu, KVM_SET_GUEST_DEBUG, > &dbg_data->dbg); > } > =20 >=20 Queued, thanks - or if Christian wants to send a pull request himself, he can go ahead. Paolo